-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] Fix JSON functions parsing #11624
Merged
GuptaManan100
merged 2 commits into
vitessio:release-14.0
from
planetscale:json-path-fix-14
Nov 3, 2022
Merged
[14.0] Fix JSON functions parsing #11624
GuptaManan100
merged 2 commits into
vitessio:release-14.0
from
planetscale:json-path-fix-14
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
added
Type: Bug
Component: Query Serving
Backport
This is a backport
labels
Nov 2, 2022
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
systay
approved these changes
Nov 2, 2022
This was referenced May 22, 2023
This was referenced Jun 20, 2023
This was referenced Feb 2, 2024
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was reported that JSON functions in their parsing fail to accept other functions as inputs and only accept the literal strings as parameters. This was fixed in release-15.0 by #10547 but the commit that fixed wasn't backported.
This PR backports the commit 7d29835 which fixes this issue. An additional test case for the query has also been added.
Related Issue(s)
Checklist
Deployment Notes