Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backups: Support InnoDB Redo Log Location With 8.0.30+ #10847

Merged
merged 28 commits into from
Jul 30, 2022
Merged

Backups: Support InnoDB Redo Log Location With 8.0.30+ #10847

merged 28 commits into from
Jul 30, 2022

Commits on Jul 26, 2022

  1. Support default InnoDB Redo log location with 8.0.30+ 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    d5b167c View commit details
    Browse the repository at this point in the history

  2. Adjustments after local testing 

    Testing was done with:
cd examples/local
./401_teardown.sh;  ./101_initial_cluster.sh; ./backups/take_backups.sh

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    d0d86e2 View commit details
    Browse the repository at this point in the history

  3. Fix unit test and add capability 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    53377f1 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/main' into 8.0.30_builtin_backups 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    e4410e4 View commit details
    Browse the repository at this point in the history

  5. Centralize check and handling 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    53d6a0e View commit details
    Browse the repository at this point in the history

  6. Minor improvements after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    6cfc965 View commit details
    Browse the repository at this point in the history

  7. Nitty nitter nits 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    b0165b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Fix findFilesToBackup logic 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f690ac8 View commit details
    Browse the repository at this point in the history

  2. Try pinning the ubuntu and MySQL version 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f0f5a1a View commit details
    Browse the repository at this point in the history

  3. Pin MySQL to 8.0.29 with direct downloads 

    The apt repo does not have older versions in it :-(

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    4b2fc86 View commit details
    Browse the repository at this point in the history

  4. No 8.0.29 packages for Ubuntu 20.04... 

    And we need to download more dependencies

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    1a9fcb9 View commit details
    Browse the repository at this point in the history

  5. Yet more remote deps; and make it more readable 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    4d6f7cb View commit details
    Browse the repository at this point in the history

  6. Try to fix builtinbackupengine unit test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    119dd6e View commit details
    Browse the repository at this point in the history

  7. Fix yet another unit test 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f72ee1f View commit details
    Browse the repository at this point in the history

  8. Add underlying flavor capability and leverage in unit tests 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    cc4ec32 View commit details
    Browse the repository at this point in the history

  9. Correct capableOf usage 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    4fb5b97 View commit details
    Browse the repository at this point in the history

  10. Correct pin revert TODO 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    d68a3ae View commit details
    Browse the repository at this point in the history

  11. Fix more unit tests 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    e268ee5 View commit details
    Browse the repository at this point in the history

  12. We should also backup any files in the innodb_log_group_home_dir 

    There's likely to be files there over time, other than the redo
logs which are in the subdir.

Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2235f75 View commit details
    Browse the repository at this point in the history

  13. Adjust unit test for new behavior 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a67c05c View commit details
    Browse the repository at this point in the history

  14. Use std has prefix for capability method 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    685678f View commit details
    Browse the repository at this point in the history

  15. Refactoring 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    33e91fc View commit details
    Browse the repository at this point in the history

  16. Minor changes after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3e77b13 View commit details
    Browse the repository at this point in the history

  17. Will stop nitting now... 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    79253c2 View commit details
    Browse the repository at this point in the history

  18. We DO NOT want the direntry in the files to backup 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    b506a78 View commit details
    Browse the repository at this point in the history

  19. Address review comments 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    40e9c29 View commit details
    Browse the repository at this point in the history

  20. Correct function comments 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    1fa2392 View commit details
    Browse the repository at this point in the history

  21. Minor changes after self review 

    Signed-off-by: Matt Lord <[email protected]>
    @mattlord
    mattlord committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    3220ef4 View commit details
    Browse the repository at this point in the history