Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: even more logging #10615

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Online DDL: even more logging #10615

merged 2 commits into from
Jun 30, 2022

Conversation

shlomi-noach
Copy link
Contributor

Description

Followup to #10482

In this PR:

  • a migration RETRY clears the error message
  • more logging upon:
    • setting new status
    • setting new error message
    • finding a stale migration
    • terminating a migration

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Jun 29, 2022
@shlomi-noach shlomi-noach requested a review from a team June 29, 2022 11:52
rohit-nayak-ps
rohit-nayak-ps approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@shlomi-noach shlomi-noach merged commit 151c905 into vitessio:main Jun 30, 2022
@shlomi-noach shlomi-noach deleted the online-ddl-logging-error-retry branch June 30, 2022 05:20
rsajwani pushed a commit to planetscale/vitess that referenced this pull request Aug 1, 2022
@shlomi-noach @rohit-nayak-ps
Online DDL: even more logging (vitessio#10615) (vitessio#798)
533e96d 
* clean error message upon RETRY

Signed-off-by: Shlomi Noach <[email protected]>

* auditing change of status, change of message, termination, finding stale migration

Signed-off-by: Shlomi Noach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shlomi-noach @rohit-nayak-ps