-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup/Restore: add support for external compressors and decompressors #10558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsajwani
requested review from
deepthi,
rohit-nayak-ps and
mattlord
as code owners
June 27, 2022 17:01
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
rsajwani
force-pushed
the
ExtDecompressor
branch
from
June 28, 2022 00:12
64d2b06
to
a2d96fa
Compare
deepthi
reviewed
Jun 28, 2022
deepthi
reviewed
Jun 28, 2022
Signed-off-by: Rameez Sajwani <[email protected]>
deepthi
reviewed
Jul 6, 2022
deepthi
added
release notes
and removed
release notes (needs details)
This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...)
labels
Jul 6, 2022
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
rvrangel
approved these changes
Jul 7, 2022
deepthi
reviewed
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there was one place missed when flags were renamed in the original PR.
Signed-off-by: Rameez Sajwani <[email protected]>
2 tasks
3 tasks
systay
pushed a commit
to planetscale/vitess
that referenced
this pull request
Aug 19, 2022
…itessio#950) * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * go mod tidy + comments Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add copyright notices Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add support for builtin engine Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <[email protected]> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <[email protected]> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <[email protected]> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <[email protected]> * fixing linter errors Signed-off-by: Rameez Sajwani <[email protected]> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <[email protected]> * removing lint warning Signed-off-by: Rameez Sajwani <[email protected]> * fixing test failure Signed-off-by: Rameez Sajwani <[email protected]> * Removing un-necessary test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing code review feeback Signed-off-by: Rameez Sajwani <[email protected]> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <[email protected]> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <[email protected]> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <[email protected]> * Fixing typos in summary Signed-off-by: Rameez Sajwani <[email protected]> * Fixing flag name typos Signed-off-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * cherry-pick some how didn't took the right code for test Signed-off-by: Rameez Sajwani <[email protected]> * Remove built-in decompression flag (vitessio#10670) * Remove built-in decompression flag Signed-off-by: Rameez Sajwani <[email protected]> * Fix test failures Signed-off-by: Rameez Sajwani <[email protected]> * Fix Helpoutput test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing unit test Signed-off-by: Rameez Sajwani <[email protected]> * Adding summary Signed-off-by: Rameez Sajwani <[email protected]> * code cleaning and better summary Signed-off-by: Rameez Sajwani <[email protected]> * Change builtinCompressor to more generic compression engine name Signed-off-by: Rameez Sajwani <[email protected]> * Fixing / Adding new test case Signed-off-by: Rameez Sajwani <[email protected]> * Fix summary & static code analysis Signed-off-by: Rameez Sajwani <[email protected]> * Adding fake backup impl in test Signed-off-by: Rameez Sajwani <[email protected]> * Adding time sleep in between test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing summary and adding comments Signed-off-by: Rameez Sajwani <[email protected]> * Feedback on summary Signed-off-by: Rameez Sajwani <[email protected]> * Code review feedback Signed-off-by: Rameez Sajwani <[email protected]> * Fixing comment Signed-off-by: Rameez Sajwani <[email protected]> * Fixing default value in summary Signed-off-by: Rameez Sajwani <[email protected]> * Fixing test cases Signed-off-by: Rameez Sajwani <[email protected]> * More summary fixes Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * Fixing TestHelpOutput Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]>
3 tasks
This was referenced Jan 5, 2023
timvaillancourt
pushed a commit
to slackhq/vitess
that referenced
this pull request
Aug 17, 2023
vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * go mod tidy + comments Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add copyright notices Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add support for builtin engine Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <[email protected]> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <[email protected]> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <[email protected]> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <[email protected]> * fixing linter errors Signed-off-by: Rameez Sajwani <[email protected]> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <[email protected]> * removing lint warning Signed-off-by: Rameez Sajwani <[email protected]> * fixing test failure Signed-off-by: Rameez Sajwani <[email protected]> * Removing un-necessary test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing code review feeback Signed-off-by: Rameez Sajwani <[email protected]> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <[email protected]> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <[email protected]> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <[email protected]> * Fixing typos in summary Signed-off-by: Rameez Sajwani <[email protected]> * Fixing flag name typos Signed-off-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]>
4 tasks
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Aug 30, 2023
…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <[email protected]> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <[email protected]> * Remove vtctl commands Signed-off-by: Matt Lord <[email protected]> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <[email protected]> * WaitForDrain related stragglers Signed-off-by: Matt Lord <[email protected]> * Legacy local straggler workflow Signed-off-by: Matt Lord <[email protected]> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <[email protected]> * Remove vtworker stragglers Signed-off-by: Matt Lord <[email protected]> * Update throttlerservice protobuf Signed-off-by: Matt Lord <[email protected]> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <[email protected]> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <[email protected]> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Correct vtgate help output Signed-off-by: Matt Lord <[email protected]> * go fmt Signed-off-by: Tim Vaillancourt <[email protected]> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * generate vtadmin files Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <[email protected]> * Merge from main Signed-off-by: Arvind Murty <[email protected]> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <[email protected]> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <[email protected]> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <[email protected]> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * go mod tidy + comments Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add copyright notices Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add support for builtin engine Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <[email protected]> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <[email protected]> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <[email protected]> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <[email protected]> * fixing linter errors Signed-off-by: Rameez Sajwani <[email protected]> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <[email protected]> * removing lint warning Signed-off-by: Rameez Sajwani <[email protected]> * fixing test failure Signed-off-by: Rameez Sajwani <[email protected]> * Removing un-necessary test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing code review feeback Signed-off-by: Rameez Sajwani <[email protected]> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <[email protected]> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <[email protected]> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <[email protected]> * Fixing typos in summary Signed-off-by: Rameez Sajwani <[email protected]> * Fixing flag name typos Signed-off-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <[email protected]> * Add 8.0 workflow Signed-off-by: Matt Lord <[email protected]> * whitespace Signed-off-by: Matt Lord <[email protected]> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <[email protected]> * Remove extraneous changes Signed-off-by: Matt Lord <[email protected]> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <[email protected]> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <[email protected]> * Specify stream type everywhere Signed-off-by: Matt Lord <[email protected]> * Remove repeated server install Signed-off-by: Matt Lord <[email protected]> * Moar... Signed-off-by: Matt Lord <[email protected]> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <[email protected]> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <[email protected]> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <[email protected]> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <[email protected]> * Test increasing timeout at another level Signed-off-by: Matt Lord <[email protected]> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <[email protected]> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <[email protected]> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <[email protected]> * Bump it more :( Signed-off-by: Matt Lord <[email protected]> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <[email protected]> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <[email protected]> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <[email protected]> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <[email protected]> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <[email protected]> * Explicitly skip new linter check Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <[email protected]> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <[email protected]> * Fix lint Signed-off-by: Tim Vaillancourt <[email protected]> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <[email protected]> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <[email protected]> * Run make web_build to compile production files Signed-off-by: notfelineit <[email protected]> * Remove vars from test Signed-off-by: notfelineit <[email protected]> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Arvind Murty <[email protected]> Signed-off-by: notfelineit <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Arvind Murty <[email protected]> Co-authored-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Co-authored-by: Frances Thai <[email protected]>
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Sep 1, 2023
…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <[email protected]> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <[email protected]> * Remove vtctl commands Signed-off-by: Matt Lord <[email protected]> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <[email protected]> * WaitForDrain related stragglers Signed-off-by: Matt Lord <[email protected]> * Legacy local straggler workflow Signed-off-by: Matt Lord <[email protected]> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <[email protected]> * Remove vtworker stragglers Signed-off-by: Matt Lord <[email protected]> * Update throttlerservice protobuf Signed-off-by: Matt Lord <[email protected]> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <[email protected]> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <[email protected]> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Address review comments Signed-off-by: Matt Lord <[email protected]> * Correct vtgate help output Signed-off-by: Matt Lord <[email protected]> * go fmt Signed-off-by: Tim Vaillancourt <[email protected]> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <[email protected]> * generate vtadmin files Signed-off-by: Arvind Murty <[email protected]> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <[email protected]> * Merge from main Signed-off-by: Arvind Murty <[email protected]> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <[email protected]> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <[email protected]> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <[email protected]> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * go mod tidy + comments Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add copyright notices Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * add support for builtin engine Signed-off-by: Renan Rangel <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <[email protected]> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <[email protected]> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <[email protected]> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <[email protected]> * fixing linter errors Signed-off-by: Rameez Sajwani <[email protected]> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <[email protected]> * removing lint warning Signed-off-by: Rameez Sajwani <[email protected]> * fixing test failure Signed-off-by: Rameez Sajwani <[email protected]> * Removing un-necessary test Signed-off-by: Rameez Sajwani <[email protected]> * Fixing code review feeback Signed-off-by: Rameez Sajwani <[email protected]> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <[email protected]> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <[email protected]> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <[email protected]> * Fixing typos in summary Signed-off-by: Rameez Sajwani <[email protected]> * Fixing flag name typos Signed-off-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <[email protected]> * Add 8.0 workflow Signed-off-by: Matt Lord <[email protected]> * whitespace Signed-off-by: Matt Lord <[email protected]> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <[email protected]> * Remove extraneous changes Signed-off-by: Matt Lord <[email protected]> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <[email protected]> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <[email protected]> * Specify stream type everywhere Signed-off-by: Matt Lord <[email protected]> * Remove repeated server install Signed-off-by: Matt Lord <[email protected]> * Moar... Signed-off-by: Matt Lord <[email protected]> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <[email protected]> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <[email protected]> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <[email protected]> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <[email protected]> * Test increasing timeout at another level Signed-off-by: Matt Lord <[email protected]> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <[email protected]> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <[email protected]> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <[email protected]> * Bump it more :( Signed-off-by: Matt Lord <[email protected]> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <[email protected]> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <[email protected]> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <[email protected]> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <[email protected]> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <[email protected]> * Explicitly skip new linter check Signed-off-by: Matt Lord <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <[email protected]> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <[email protected]> * Fix lint Signed-off-by: Tim Vaillancourt <[email protected]> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <[email protected]> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <[email protected]> * Run make web_build to compile production files Signed-off-by: notfelineit <[email protected]> * Remove vars from test Signed-off-by: notfelineit <[email protected]> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <[email protected]> --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Arvind Murty <[email protected]> Signed-off-by: notfelineit <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Arvind Murty <[email protected]> Co-authored-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Co-authored-by: Frances Thai <[email protected]>
timvaillancourt
added a commit
to slackhq/vitess
that referenced
this pull request
Sep 4, 2023
…test + compressors (#119) (#124) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code * Move used until functions from initialsharding to cluster * Remove vtctl commands * Kill vtworker and SetKeyspaceServedFrom cmd * WaitForDrain related stragglers * Legacy local straggler workflow * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers * Remove vtworker stragglers * Update throttlerservice protobuf * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) * Remove last mentiones of legacy sharding in vtctl * remove binlog_use_v3_resharding_mode * Address review comments * Address review comments * Correct vtgate help output * go fmt * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * generate vtadmin files * cleanup: remove sharding_column_name and sharding_column_type from vtadmin * Merge from main * Fix bad merge conflict resolution * Fix missing 'sharding' import * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor * add external compressor support + builtin additional compressors * wrap external compressor/decompressor * go mod tidy + comments * add copyright notices * add support for builtin engine * Adding test case for buckup compression * Fixing unit test and run mod tidy * Removing unwanted unit tests * Increase timeout of backup tests * fixing linter errors * Change test logic to accomodate running selective tests * removing lint warning * fixing test failure * Removing un-necessary test * Fixing code review feeback * Change builtinEngine to consider 'auto' decompressor * fixing Upgrade/Downgrade test * Fix type & add summary under release notes * Fixing typos in summary * Fixing flag name typos * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests * Add 8.0 workflow * whitespace * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. * Remove extraneous changes * We need lz4 for TestXtrabackupStreamWithlz4Compression * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions * Specify stream type everywhere * Remove repeated server install * Moar... * Move vtctlbackup test to 8.0 * Rename vtbackup test and move to MySQL 8 * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. * Use MySQL 8 compat method for setting passwords * Test increasing timeout at another level * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. * Fix incorrect password update statement for vt_repl user * Bump timeouts for 8.0 backup tests * Bump it more :( * Increase backup/restore timeout in backup_utils * Apply new 8.0 template everywhere * Fix bugs around how the compression flags were getting passed * Use 45m timeout for the workflow, 30m for the run. * These changes were no longer needed so limiting diff. * Explicitly skip new linter check * Fix test file merge issues * Go 1.18.7 to fix error * Fix lint * Fix vttablet.txt * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type * Run make web_build to compile production files * Remove vars from test * Remove sharding column type select box test from web test --------- Signed-off-by: Matt Lord <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Arvind Murty <[email protected]> Signed-off-by: notfelineit <[email protected]> Co-authored-by: Matt Lord <[email protected]> Co-authored-by: Arvind Murty <[email protected]> Co-authored-by: Rameez Sajwani <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Renan Rangel <[email protected]> Co-authored-by: Rohit Nayak <[email protected]> Co-authored-by: Frances Thai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement PR for #7978
Signed-off-by: Renan Rangel [email protected]
This change will allow us to use an external decompressor when available as opposed to the internal pgzip currently used. We ran some tests using pigz -d -c and we get a nice speed bump on decompression, around 30% or more faster decompressing when restoring from a backup in S3. While decompressing is still single-threaded in pigz, it uses separate threads for reading, writing and checksum, and it results in faster performance.
I wanted to get an initial feedback on this change, as we would like to also to plug our own compressor to use other encryption algorithms (like lz4 or zstd) with an external binary as this is a more flexible setup for users, but also work on the change to add built-in support for one of these compression algorithms.
Related Issue(s)
#7802
Checklist
Deployment Notes