Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlparser: fix canonical formatting for enums #10149

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Apr 27, 2022

Description

Fixes #10143, requested by @shlomi-noach

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Shlomi Noach <[email protected]>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@shlomi-noach
Copy link
Contributor

shlomi-noach commented Apr 27, 2022

Cluster (20) doesn't want to complete. 3rd round where it's just hanging for over 30-40min

@shlomi-noach
Copy link
Contributor

Cluster (20) fails consistently for some 7-8 times now; but it does not seem to be related to this PR. Any thoughts?

@GuptaManan100
Copy link
Member

GuptaManan100 commented Apr 27, 2022

Oh, that not a required test anymore. There was a new version released of XtraBackup which is breaking the test. Here is the open issue for it - #10146. It was created yesterday, and for the time being the test is marked not required. It should be okay to merge 👍

@shlomi-noach shlomi-noach merged commit 168b30d into vitessio:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlparser.CanonicalString() capitalizes enum values
4 participants