Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitClone could add a schema check of source and destination shards prior to starting #3239

Closed
sjmudd opened this issue Sep 23, 2017 · 1 comment

Comments

@sjmudd
Copy link
Contributor

sjmudd commented Sep 23, 2017

The time to do this should be minimal and it avoids problems coming up after a long run copying data from one shard to one or more.

Background: I had been setting up a manual SplitClone for testing the workflow, I'd had some issues with it and eventually figured out what to do but in the immediate term I had not recopied the database schema again from source to destination. The SplitClone workflow does not seem to check this and consequently after several hours of running the process it failed.

I'm not sure how DDLs are managed in Vitess (not looked yet) so maybe you want potentially for the destination and source shards to be different but in my case this caught me and this issue is just to make a note of this.

If it does not make sense to add such a check that's also fine but it would be useful to know the reasoning for that.

@mattlord
Copy link
Contributor

Closing for now as SplitClone has been replaced by MoveTables in 6.0+. Please let me know if I misunderstood something. Thanks!

frouioui pushed a commit to planetscale/vitess that referenced this issue Mar 26, 2024
* cherry pick of 14069

* regenerate flag testdata

Signed-off-by: Andrew Mason <[email protected]>

---------

Signed-off-by: Andrew Mason <[email protected]>
Co-authored-by: Andrew Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants