Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increment counter for warnings #3028

Closed
acharis opened this issue Aug 2, 2017 · 1 comment
Closed

increment counter for warnings #3028

acharis opened this issue Aug 2, 2017 · 1 comment
Labels
Type: Feature

Comments

@acharis
Copy link
Contributor

acharis commented Aug 2, 2017 •
edited
Loading

tabletenv.go now has a counter for Warnings, but only one call to log.Warn* is accompanied by a counter increment. we should create other appropriate counters under "Warnings" and add increments wherever log.Warn* is called
@mattlord
Copy link
Contributor

I'm closing this for now as I'm unsure if it's still relevant -- we no longer have a tabletenv.go file -- and from a quick glance at the code I don't see the issue original mentioned. If it's still an issue let me know and we can re-open it with some additional details.

Thanks!

frouioui pushed a commit to planetscale/vitess that referenced this issue Mar 26, 2024
@planetscale-actions-bot @shlomi-noach
CherryPick(vitessio#13860): vtctldclient OnlineDDL CANCEL (vitessio#3028
7b57e4f 
)

* cherry pick of 13860

* make proto: resolve conflict

Signed-off-by: Shlomi Noach <[email protected]>

* resolve conflict

Signed-off-by: Shlomi Noach <[email protected]>

---------

Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sougou @mattlord @acharis