Generating copy-on-rewrite logic (#12135)

* add code for generating copy-on-rewrite logic Signed-off-by: Andres Taylor <[email protected]> * added more tests and started calling cloned Signed-off-by: Andres Taylor <[email protected]> * reformat Signed-off-by: Andres Taylor <[email protected]> * change uses of Clone & Rewrite to CopyOnRewrite Signed-off-by: Andres Taylor <[email protected]> * regenerate test code Signed-off-by: Andres Taylor <[email protected]> Signed-off-by: Andres Taylor <[email protected]>
vitessio · Jan 24, 2023 · ca8c233 · ca8c233
1 parent 784d79c
commit ca8c233
Show file tree

Hide file tree

Showing 28 changed files with 8,056 additions and 168 deletions.
diff --git a/go/tools/asthelpergen/asthelpergen.go b/go/tools/asthelpergen/asthelpergen.go
@@ -31,7 +31,7 @@ import (
 	"golang.org/x/tools/go/packages"
 )
 
-const licenseFileHeader = `Copyright 2021 The Vitess Authors.
+const licenseFileHeader = `Copyright 2023 The Vitess Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -244,6 +244,7 @@ func GenerateASTHelpers(options *Options) (map[string]*jen.File, error) {
 		newCloneGen(pName, &options.Clone),
 		newVisitGen(pName),
 		newRewriterGen(pName, types.TypeString(nt, noQualifier)),
+		newCOWGen(pName, nt),
 	)
 
 	it, err := generator.GenerateCode()

diff --git a/go/tools/asthelpergen/clone_gen.go b/go/tools/asthelpergen/clone_gen.go
@@ -93,7 +93,7 @@ func (c *cloneGen) sliceMethod(t types.Type, slice *types.Slice, spi generatorSP
 	funcName := cloneName + name
 
 	c.addFunc(funcName,
-		//func (n Bytes) Clone() Bytes {
+		// func (n Bytes) Clone() Bytes {
 		jen.Func().Id(funcName).Call(jen.Id("n").Id(typeString)).Id(typeString).Block(
 			// if n == nil { return nil }
 			ifNilReturnNil("n"),
@@ -116,9 +116,9 @@ func (c *cloneGen) copySliceElement(t types.Type, elType types.Type, spi generat
 		return jen.Id("copy").Call(jen.Id("res"), jen.Id("n"))
 	}
 
-	//for i := range n {
+	// for i := range n {
 	//  res[i] = CloneAST(x)
-	//}
+	// }
 	spi.addType(elType)
 
 	return jen.For(jen.List(jen.Id("i"), jen.Id("x"))).Op(":=").Range().Id("n").Block(
@@ -128,17 +128,17 @@ func (c *cloneGen) copySliceElement(t types.Type, elType types.Type, spi generat
 
 func (c *cloneGen) interfaceMethod(t types.Type, iface *types.Interface, spi generatorSPI) error {
 
-	//func CloneAST(in AST) AST {
+	// func CloneAST(in AST) AST {
 	//	if in == nil {
 	//	return nil
-	//}
+	// }
 	//	switch in := in.(type) {
-	//case *RefContainer:
+	// case *RefContainer:
 	//	return in.CloneRefOfRefContainer()
-	//}
+	// }
 	//	// this should never happen
 	//	return nil
-	//}
+	// }
 
 	typeString := types.TypeString(t, noQualifier)
 	typeName := printableTypeName(t)
@@ -196,7 +196,7 @@ func (c *cloneGen) ptrToBasicMethod(t types.Type, _ *types.Basic, spi generatorS
 func (c *cloneGen) ptrToOtherMethod(t types.Type, ptr *types.Pointer, spi generatorSPI) error {
 	receiveType := types.TypeString(t, noQualifier)
 
-	funcName := "Clone" + printableTypeName(t)
+	funcName := cloneName + printableTypeName(t)
 	c.addFunc(funcName,
 		jen.Func().Id(funcName).Call(jen.Id("n").Id(receiveType)).Id(receiveType).Block(
 			ifNilReturnNil("n"),
@@ -224,7 +224,7 @@ func (c *cloneGen) ptrToStructMethod(t types.Type, strct *types.Struct, spi gene
 	receiveType := types.TypeString(t, noQualifier)
 	funcName := cloneName + printableTypeName(t)
 
-	//func CloneRefOfType(n *Type) *Type
+	// func CloneRefOfType(n *Type) *Type
 	funcDeclaration := jen.Func().Id(funcName).Call(jen.Id("n").Id(receiveType)).Id(receiveType)
 
 	if slices.Contains(c.exclude, receiveType) {