Skip to content

Commit

Permalink
Merge pull request #5953 from planetscale/ss-proto-nopy
Browse files Browse the repository at this point in the history
proto: remove python builds
  • Loading branch information
morgo authored Mar 23, 2020
2 parents d06c755 + 101ea77 commit 8db38d1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,10 @@ endif

PROTO_SRCS = $(wildcard proto/*.proto)
PROTO_SRC_NAMES = $(basename $(notdir $(PROTO_SRCS)))
PROTO_PY_OUTS = $(foreach name, $(PROTO_SRC_NAMES), py/vtproto/$(name)_pb2.py)
PROTO_GO_OUTS = $(foreach name, $(PROTO_SRC_NAMES), go/vt/proto/$(name)/$(name).pb.go)

# This rule rebuilds all the go and python files from the proto definitions for gRPC.
proto: proto_banner $(PROTO_GO_OUTS) $(PROTO_PY_OUTS)
proto: proto_banner $(PROTO_GO_OUTS)

proto_banner:
ifeq (,$(PROTOC_COMMAND))
Expand All @@ -180,9 +179,6 @@ ifndef NOBANNER
echo $$(date): Compiling proto definitions
endif

$(PROTO_PY_OUTS): py/vtproto/%_pb2.py: proto/%.proto
$(PROTOC_COMMAND) -Iproto $< --python_out=py/vtproto --grpc_python_out=py/vtproto

# TODO(sougou): find a better way around this temp hack.
VTTOP=$(VTROOT)/../../..
$(PROTO_GO_OUTS): install_protoc-gen-go proto/*.proto
Expand Down
3 changes: 2 additions & 1 deletion go/vt/proto/vtgate/vtgate.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 8db38d1

Please sign in to comment.