Pin MySQL to 8.0.29 with direct downloads

The apt repo does not have older versions in it :-( Signed-off-by: Matt Lord <[email protected]>
vitessio · Jul 27, 2022 · 4b2fc86 · 4b2fc86
1 parent f0f5a1a
commit 4b2fc86
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 14 deletions.
diff --git a/.github/workflows/upgrade_downgrade_test_backups_manual.yml b/.github/workflows/upgrade_downgrade_test_backups_manual.yml
@@ -10,8 +10,8 @@ concurrency:
 jobs:
   get_previous_release:
     if: always() && github.event_name == 'pull_request'
-    name: Get latest release
-    runs-on: ubuntu-20.04
+    name: Get latest LTS release
+    runs-on: ubuntu-22.04
     outputs:
       previous_release: ${{ steps.output-previous-release-ref.outputs.previous_release_ref }}
 
@@ -33,7 +33,7 @@ jobs:
     timeout-minutes: 40
     if: always() && (needs.get_previous_release.result == 'success')
     name: Run Upgrade Downgrade Test
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs:
       - get_previous_release
 
@@ -106,16 +106,22 @@ jobs:
         sudo deluser mysql
         sudo rm -rf /var/lib/mysql
         sudo rm -rf /etc/mysql
-        # Install mysql80
-        sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 467B942D3A79BD29
-        wget -c https://dev.mysql.com/get/mysql-apt-config_0.8.20-1_all.deb
-        echo mysql-apt-config mysql-apt-config/select-server select mysql-8.0 | sudo debconf-set-selections
-        sudo DEBIAN_FRONTEND="noninteractive" dpkg -i mysql-apt-config*
-        sudo apt-get update
-        # Temporarily pin the MySQL version at 8.0.29 as Vitess 14.0 does not have the fix to support
-        # backups of 8.0.30. See: https://github.com/vitessio/vitess/pull/10847
-        # TODO: remove this pin once 16.0.0-SNAPSHOT becomes the dev version on main
-        sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server=8.0.29-1ubuntu20.04 mysql-client=8.0.29-1ubuntu20.04
+
+        # Install MySQL 8.0
+        ####
+        ## Temporarily pin the MySQL version at 8.0.29 as Vitess 14.0 does not have the fix to support
+        ## backups of 8.0.30+. See: https://github.com/vitessio/vitess/pull/10847
+        ## TODO: remove this pin once Vitess 16.0.0-SNAPSHOT becomes the dev version on vitessio/main
+        #sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 467B942D3A79BD29
+        #wget -c https://dev.mysql.com/get/mysql-apt-config_0.8.20-1_all.deb
+        #echo mysql-apt-config mysql-apt-config/select-server select mysql-8.0 | sudo debconf-set-selections
+        #sudo DEBIAN_FRONTEND="noninteractive" dpkg -i mysql-apt-config*
+        #sudo apt-get update
+        #sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y mysql-server mysql-client
+        ####
+        wget -c https://cdn.mysql.com/archives/mysql-8.0/mysql-server_8.0.29-1ubuntu20.04_amd64.deb https://cdn.mysql.com/archives/mysql-8.0/mysql-client_8.0.29-1ubuntu20.04_amd64.deb
+        sudo DEBIAN_FRONTEND="noninteractive" apt-get install -y ./mysql-*.deb
+
         # Install everything else we need, and configure
         sudo apt-get install -y make unzip g++ etcd curl git wget eatmydata grep
         sudo service mysql stop

diff --git a/go/vt/mysqlctl/backup_test.go b/go/vt/mysqlctl/backup_test.go
@@ -60,7 +60,6 @@ func TestFindFilesToBackup(t *testing.T) {
 	if err := os.WriteFile(path.Join(innodbDataDir, "innodb_data_1"), []byte("innodb data 1 contents"), os.ModePerm); err != nil {
 		t.Fatalf("failed to write file innodb_data_1: %v", err)
 	}
-	t.Logf("Writing file: %s", path.Join(innodbLogDir, innodbLogFile))
 	if err := os.WriteFile(path.Join(innodbLogDir, innodbLogFile), []byte("innodb log 1 contents"), os.ModePerm); err != nil {
 		t.Fatalf("failed to write file innodb_log_1: %v", err)
 	}