yaml: deflake pool_test

Signed-off-by: Sugu Sougoumarane <[email protected]>
vitessio · Apr 19, 2020 · 25af6e7 · 25af6e7
1 parent 8f93fc4
commit 25af6e7
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/go/vt/vttablet/tabletserver/connpool/pool_test.go b/go/vt/vttablet/tabletserver/connpool/pool_test.go
@@ -18,6 +18,7 @@ package connpool
 
 import (
 	"runtime"
+	"sync"
 	"testing"
 	"time"
 
@@ -80,7 +81,10 @@ func TestConnPoolMaxWaiters(t *testing.T) {
 	require.NoError(t, err)
 
 	// waiter 1
+	var wg sync.WaitGroup
+	wg.Add(1)
 	go func() {
+		defer wg.Done()
 		c1, err := connPool.Get(context.Background())
 		assert.NoError(t, err)
 		c1.Recycle()
@@ -92,11 +96,14 @@ func TestConnPoolMaxWaiters(t *testing.T) {
 			break
 		}
 	}
+
+	// waiter 2
 	_, err = connPool.Get(context.Background())
 	assert.EqualError(t, err, "pool TestPool waiter count exceeded")
 
 	// This recycle will make waiter1 succeed.
 	dbConn.Recycle()
+	wg.Wait()
 }
 
 func TestConnPoolGetEmptyDebugConfig(t *testing.T) {