-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(plugin-legacy): improve default polyfill #8312
Merged
patak-dev
merged 3 commits into
vitejs:main
from
sapphi-red:refactor/legacy-default-polyfill
Jun 1, 2022
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,12 +61,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] { | |
const facadeToLegacyPolyfillMap = new Map() | ||
const facadeToModernPolyfillMap = new Map() | ||
const modernPolyfills = new Set<string>() | ||
// System JS relies on the Promise interface. It needs to be polyfilled for IE 11. (array.iterator is mandatory for supporting Promise.all) | ||
const DEFAULT_LEGACY_POLYFILL = [ | ||
'core-js/modules/es.promise', | ||
'core-js/modules/es.array.iterator' | ||
] | ||
const legacyPolyfills = new Set(DEFAULT_LEGACY_POLYFILL) | ||
const legacyPolyfills = new Set<string>() | ||
|
||
if (Array.isArray(options.modernPolyfills)) { | ||
options.modernPolyfills.forEach((i) => { | ||
|
@@ -148,11 +143,13 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] { | |
|
||
// legacy bundle | ||
if (legacyPolyfills.size || genDynamicFallback) { | ||
if (!legacyPolyfills.has('es.promise')) { | ||
// check if the target needs Promise polyfill because SystemJS relies | ||
// on it | ||
await detectPolyfills(`Promise.resolve()`, targets, legacyPolyfills) | ||
} | ||
// check if the target needs Promise polyfill because SystemJS relies on it | ||
// https://github.com/systemjs/systemjs#ie11-support | ||
await detectPolyfills( | ||
`Promise.resolve(); Promise.all();`, | ||
targets, | ||
legacyPolyfills | ||
) | ||
Comment on lines
+146
to
+152
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Polyfills other than |
||
|
||
isDebug && | ||
console.log( | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
Promise.all()
makeslegacyPolyfills
to includecore-js/modules/es.array.iterator.js
.