Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: add isolatedModules to create-vite > template-vue-ts > tsconfig" #7781

Conversation

ubershmekel
Copy link

@ubershmekel ubershmekel commented Apr 18, 2022

Reverts #7304

See vuejs/core#1228

Using npm run build is broken in a clean npm create vite@latest with vue-ts. This is the beginning of the error:

node_modules/@vue/reactivity/dist/reactivity.d.ts:26:15 - error TS2748: Cannot access ambient const enums when the '--isolatedModules' flag is provided.

26     readonly [ReactiveFlags.IS_READONLY]: boolean;

@ubershmekel
Copy link
Author

@patak-dev you reviewed the original PR, so you might want to review this one.

@bluwy
Copy link
Member

bluwy commented Apr 18, 2022

This will be fixed with #7726. I don't think we need this PR.

@ubershmekel
Copy link
Author

Whatever goes live faster. Can't have npm run build broken.

@sapphi-red
Copy link
Member

Closing as #7726 is merged and released 👍

@sapphi-red sapphi-red closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants