Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): support custom regexp of css modules #6404

Closed
wants to merge 3 commits into from
Closed

feat(css): support custom regexp of css modules #6404

wants to merge 3 commits into from

Conversation

jsonz1993
Copy link

Description

close #6232 #5135

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: css p2-nice-to-have Not breaking anything but nice to have (priority) YAO Yet another option... labels Jan 6, 2022
Shinigami92
Shinigami92 suggested changes Jan 6, 2022
View reviewed changes
packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved
JackFGreen added a commit to JackFGreen/vite that referenced this pull request Jan 20, 2022
@JackFGreen
feat(css): add cssExtract option to build config (vitejs#6404)
bf03079
@jsonz1993
Copy link
Author

Does anyone have a look at this PR please?

@bluwy
Copy link
Member

bluwy commented Jan 29, 2022

There are still pending questions in #6232

@bluwy bluwy mentioned this pull request Feb 2, 2022
Closed
4 tasks
@Niputi
Copy link
Contributor

Niputi commented Feb 9, 2022

closing. you can check reasoning here #2981

@Niputi Niputi closed this Feb 9, 2022
@jsonz1993 jsonz1993 mentioned this pull request Feb 11, 2022
Open
@jsonz1993 jsonz1993 deleted the support-custom-css-modules-suffix branch February 11, 2022 07:58
@sapphi-red sapphi-red mentioned this pull request Apr 16, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
feat: css p2-nice-to-have Not breaking anything but nice to have (priority) YAO Yet another option...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support custom css modules suffix
4 participants
@jsonz1993 @bluwy @Niputi @Shinigami92