fix(ssr): robust regexp to check cjs content #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygj6
changed the title
Shinigami92
reviewed
Dec 11, 2021
| @@ -157,7 +157,9 @@ function collectExternals( | |||
| } | |||
| // check if the entry is cjs | |||
| const content = fs.readFileSync(esmEntry, 'utf-8') | |||
| if (/\bmodule\.exports\b|\bexports[.\[]|\brequire\s*\(/.test(content)) { | |||
| const CJS_CONTENT_RE = | |||
There was a problem hiding this comment.
suggestion: We could move this constant out of the function scope
bluwy
previously approved these changes
Dec 11, 2021
This was referenced Dec 13, 2021
Shinigami92
approved these changes
Dec 13, 2021
patak-dev
approved these changes
Dec 13, 2021
bluwy
approved these changes
Dec 13, 2021
|
Thanks @ygj6 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some dependencies can be externalized
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).