Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize internal plugin names #4976

Merged
merged 2 commits into from
Sep 19, 2021
Merged

fix: normalize internal plugin names #4976

merged 2 commits into from
Sep 19, 2021

Conversation

patak-dev
Copy link
Member

Description

Ensure that all internal and official plugins names follow the 'vite:{name}' format.
Plugin React and Vue were already using this format, but legacy and vue-jsx were not. There were several internal plugins that weren't following either.

Since we are now recommending the use of @antfu's https://github.com/antfu/vite-plugin-inspect, people will start to see and maybe rely on these names. This is a breaking change but I think it can safely be applied as part of the 2.6 beta


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added this to the 2.6 milestone Sep 18, 2021
antfu
antfu previously approved these changes Sep 18, 2021
@patak-dev
Copy link
Member Author

@benmccann would you check this one just in case SvelteKit is removing or swapping a plugin by name?

Shinigami92
Shinigami92 previously approved these changes Sep 18, 2021
packages/vite/src/node/plugins/loadFallback.ts Outdated Show resolved Hide resolved
@patak-dev patak-dev dismissed stale reviews from Shinigami92 and antfu via a45e68e September 18, 2021 20:24
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antfu's review should still count 😅
Feel free to merge

@benmccann
Copy link
Collaborator

This is fine from my end. Thanks for checking

@patak-dev patak-dev merged commit 37f0b2f into main Sep 19, 2021
@patak-dev patak-dev deleted the normalize-plugin-names branch September 19, 2021 08:37
ygj6 pushed a commit to ygj6/vite that referenced this pull request Sep 22, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants