Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add esbuid-bundle plugin #4677

Closed
wants to merge 1 commit into from

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Aug 21, 2021

Description

fix #3193, add an vite plugin to bundle third party module to speed up and handle better cjs interop

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hardfist hardfist force-pushed the add-esbuild-bundle branch from c115717 to 5bde264 Compare August 21, 2021 12:39
@hardfist
Copy link
Contributor Author

hardfist commented Aug 21, 2021

It can handle JS code splitting now ,but due to the limitation of rollup(rollup/rollup#4210), It's hard to handle css code splitting and js preload. @sodatea @yyx990803
image

@Shinigami92
Copy link
Member

You should not create a plugin here in the vite repo, but just a plugin living in it's own repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using esbuild to bundle node_modules instead of commonjs to speed up build
2 participants