fix: skip asset emit for legacy output #3317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqunjiang
suggested changes
Sep 22, 2021
| @@ -219,6 +219,9 @@ function viteLegacyPlugin(options = {}) { | |||
| // @ts-ignore avoid esbuild transform on legacy chunks since it produces | |||
| // legacy-unsafe code - e.g. rewriting object properties into shorthands | |||
| opts.__vite_skip_esbuild__ = true | |||
| // @ts-ignore | |||
| // inject flag to prevent emit assets for legacy bundle | |||
| opts.__vite_legacy = true | |||
There was a problem hiding this comment.
Suggested change
| opts.__vite_legacy = true | |
| opts.__vite_skip_asset_emit__ = true |
- Adds
__at the end to be consistent with__vite_skip_esbuild__ - Describes the actual consequence of the flag
haoqunjiang
added a commit
to haoqunjiang/vite
that referenced
this pull request
Jan 21, 2022
Fixes vitejs#3296 Supersedes vitejs#3317 The asset emitting conflict may also exist for other types of assets, but let's fix the CSS one first. The conflict here is due to the `hasEmitted` flag that was originally intended to avoid duplicated CSS for multiple output formats vitejs@6bce108#diff-2cfbd4f4d8c32727cd8e1a561cffbde0b384a3ce0789340440e144f9d64c10f6R262-R263 When the legacy plugin is used, the flag was set to `true` for the emitted CSS of the legacy bundle. But the legacy plugin would remove all its emitted assets later to avoid duplication. So this logic results in no CSS to be actually emitted. In this PR, I used a `__vite_skip_asset_emit__` flag to prevent the CSS `generateBundle` from executing for the legacy build. If other asset emitting plugins encounter similar issues, this flag can be reused.
9 tasks
patak-dev
pushed a commit
that referenced
this pull request
Jan 28, 2022
Fixes #3296 Supersedes #3317 The asset emitting conflict may also exist for other types of assets, but let's fix the CSS one first. The conflict here is due to the `hasEmitted` flag that was originally intended to avoid duplicated CSS for multiple output formats 6bce108#diff-2cfbd4f4d8c32727cd8e1a561cffbde0b384a3ce0789340440e144f9d64c10f6R262-R263 When the legacy plugin is used, the flag was set to `true` for the emitted CSS of the legacy bundle. But the legacy plugin would remove all its emitted assets later to avoid duplication. So this logic results in no CSS to be actually emitted. In this PR, I used a `__vite_skip_asset_emit__` flag to prevent the CSS `generateBundle` from executing for the legacy build. If other asset emitting plugins encounter similar issues, this flag can be reused.
|
Superseded by #6584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3296
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).