fix: revert #2541, fix #3084 #3101 #3144
Merged
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1451b78.
Shinigami92
added
the
p3-minor-bug
Shinigami92
approved these changes
Apr 25, 2021
nihalgonsalves
approved these changes
Apr 25, 2021
patak-dev
changed the title
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
This reverts commit 1451b78.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1451b78.
Description
Fixes #3084 and #3101
#2541 introduced a regression, to fix an edge case. This PR reverts that 3 lines change so we can release a patch and later rework a better solution for the issue described in #2541
What is the purpose of this pull request?