Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): depScan resolve with flatIdDeps #3053

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix(optimizer): depScan resolve with flatIdDeps #3053

merged 1 commit into from
Apr 19, 2021

Conversation

nihalgonsalves
Copy link
Member

Description

v2.2.0 broke my build (and other users in Vite Land) with hundreds of errors such as these:

 > node_modules/.pnpm/@[email protected]_ba191c0052acfa37659f3ba04a2d9405/node_modules/@material-ui/core/es/styles/index.js:13:136: error: [vite:dep-pre-bundle] Cannot find module '@material-ui_styles'
Require stack:
- <redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-8baf35b6.js
- <redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/cli.js
- <redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/vite/bin/vite.js
       13 │ export { createGenerateClassName, jssPreset, ServerStyleSheets, StylesProvider, ThemeProvider as MuiThemeProvider, ThemeProvider } from '@material-ui/styles';
          ╵                                                                                                                                         ~~~~~~~~~~~~~~~~~~~~~
   node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-8baf35b6.js:65417:18: note: This error came from the "onResolve" callback registered here
    65417 │             build.onResolve({ filter: /^[\w@][^:]/ }, async ({ path: id, importer, kind, resolveDir }) => {
          ╵                   ~~~~~~~~~
    at setup (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-8baf35b6.js:65417:19)
    at handlePlugins (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:686:7)
    at Object.buildOrServe (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:903:44)
    at <redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1444:17
    at new Promise (<anonymous>)
    at Object.build (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1443:14)
    at Object.build (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/esbuild/lib/main.js:1334:51)
    at optimizeDeps (<redacted:repo-root>/node_modules/.pnpm/[email protected]/node_modules/vite/dist/node/chunks/dep-8baf35b6.js:65643:34)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

I looked at the diff and it seemed to be related to this change: https://github.com/vitejs/vite/pull/3003/files#diff-7657c7c3217417a1747348410996718b471f6f0cb9552752b47a411f8f010830R94-R96

Adding back qualified[flatId] fixed it for me.

Additional context

  • Where would be the best place to add a regression test?
  • Nevertheless, this should probably be merged first since it has a big impact

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

Is it possible to add a test for this case?

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 19, 2021
@patak-dev
Copy link
Member

Let's merge this one so we can issue a release, and add tests in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants