feat(ssr): support circular dependencies in ssr #2489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach doesn't work, will reopen PR once a working approach is found. |
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2258.
Currently, whenever a circular dependency is encountered,
ssrLoadModulereturns an empty object, causing any code that requires circular dependencies to fail.The algorithm is inspired by es-module-loader. This PR changes
instantiateModuleto store the SSR Module exports object in the ModuleNode before its dependencies are loaded and before the code is executed. IfssrLoadModuledetects that it is doing a circular import, then it returns that "live"ssrModuleobject (which hasn't yet been populated yet). Once all the dependencies are loaded, thessrModuleobject is frozen.