Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix checkout pr in ecosystem ci #18942

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Aslemammad
Copy link
Contributor

As discussed in discord, right now the git ambiguity check always fails because the pr commits are yet to exist in the main history.

in this fix, we checkout to the pull request history and have a look there.

@sapphi-red
Copy link
Member

/ecosystem-ci run vite-plugin-vue

Copy link

pkg-pr-new bot commented Dec 11, 2024

Open in Stackblitz

npm i https://pkg.pr.new/vite@18942

commit: 60b8f8a

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 60b8f8a: Open

suite result latest scheduled
vite-plugin-vue failure success

@sapphi-red
Copy link
Member

It seems I can't test this out here. Let me do it on my own fork.

@sapphi-red
Copy link
Member

I confirmed that it works 👍
sapphi-red#7

@sapphi-red sapphi-red changed the title fix: checkout pr in ecosystem ci ci: fix checkout pr in ecosystem ci Dec 11, 2024
@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Dec 11, 2024
@sapphi-red sapphi-red merged commit 3400a5e into vitejs:main Dec 11, 2024
15 checks passed
@Aslemammad Aslemammad deleted the fix/checkout-pr-in-ecosystem-ci branch December 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority) trigger: preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants