Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): allow unexpected question mark in tag name #18852

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix(html): allow unexpected question mark in tag name #18852

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ddb16
fix(html): allow unexpected question mark in tag name
Christiano300 Oct 29, 2024
1eaf640
chore: add comment
sapphi-red Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/vite/src/node/plugins/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,10 @@ function handleParseError(
case 'non-void-html-element-start-tag-with-trailing-solidus':
// Allow self closing on non-void elements #10439
return
case 'unexpected-question-mark-instead-of-tag-name':
// Allow <?xml> declaration and <?> empty elements
sapphi-red marked this conversation as resolved.
Show resolved Hide resolved
// lit generates <?>: https://github.com/lit/lit/issues/2470
return
}
const parseError = formatParseError(parserError, filePath, html)
throw new Error(
Expand Down
Loading