fix: allow scan to use user provided loaders #1884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
Mar 19, 2021
Shinigami92
added
p2-nice-to-have
|
@matias-capeletto This may or may not be bumped up to |
|
Considering this twitter thread is there any chance this will get merged? |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user js sources have
jsxsyntaxes, but the file extension ends withjs, he may want to force esbuild to use "jsx/tsx" loaders in thevite.config.js.However, during the dep scan phase, the
esbuildScanPluginwill fail because esbuild will complain that js containsjsxtags.This fix will force the esbuild to use user-provided loader configs during dep scan phase to mitage this issue.