fix(ssr): format ssrTransform parse error

[hi-ogawa]

Description

(Recreated #18621 as I force-pushed the branch and Github won't let me reopen it)

• closes Log LOC for js syntax errors vitest-dev/vitest#6882

It looks like this parse error handling code is obsolete and does nothing for current rollup parse error. For non-js file, esbuild transform in plugin pipeline normally catches a syntax error, but for js file, ssrTransform needs to throw an error. Since ssrTransform is outside of transform plugin pipeline, Error.pos doesn't get prettified automatically, so I added a error processing inside the try/catch.

reproduction: https://stackblitz.com/edit/vitest-dev-vitest-wpj5mg?file=vite.config.ts

Screenshots

• v5

• this PR

[sapphi-red]

I think we should keep the error message (Parse failure: ...) so that console.log(err) shows the position and contents (#5192, #12060).

[sapphi-red]

I don't know when err.loc exsits (when it passes the previous code path) though.

[hi-ogawa]

Right, it looks better to keep Parse failure: ... for clarity. I remembered esbuild transform error also includes location details in its message (cf. #18626).

I don't know when err.loc exsits (when it passes the previous code path) though.

Probably loc check was for acorn based parser error, so it's no longer relevant. Since Rollup 4, it now only has code, message, pos properties https://github.com/rollup/rollup/blob/42e587e0e37bc0661aa39fe7ad6f1d7fd33f825c/src/utils/bufferToAst.ts#L20-L22, so we only need to target these. It looks like pos is missing on rust side panic, so I covered that case too.

[sapphi-red]

Thanks for checking! That makes sense.