refactor(runtime): share more code between runtime and main bundle #16063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p1-chore
|
|
sapphi-red
commented
Feb 29, 2024
| result.code = `${code.trimEnd()}\n//# sourceURL=${ | ||
| mod.id | ||
| }\n${VITE_RUNTIME_SOURCEMAPPING_SOURCE}\n//# ${VITE_RUNTIME_SOURCEMAPPING_URL};base64,${sourceMap}\n` |
There was a problem hiding this comment.
I removed charset=utf-8 part.
JSON should be always utf-8 and the charset in mime doesn't have any effect according to the RFC.
sapphi-red
force-pushed
the
refactor/runtime-share-code
branch
from
b0ee307
to
369c3f7
Compare
patak-dev
approved these changes
Mar 5, 2024
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, histoire, ladle, laravel, marko, nuxt, previewjs, qwik, rakkas, sveltekit, unocss, vike, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-pages, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest |
|
@sheremet-va I'll let this one open a few days in case you'd like to take a look. |
sheremet-va
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See each commits.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).