refactor(glob)!: remove import.meta.globEager
#14118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p1-chore
|
|
patak-dev
approved these changes
Aug 16, 2023
bluwy
approved these changes
Aug 21, 2023
ElMassimo
pushed a commit
to ElMassimo/stimulus-vite-helpers
that referenced
this pull request
Dec 19, 2023
The `globEager` function was deprecated as of Vite 3.0 and has been removed in Vite 5.0. This updates the README to use the suggested `glob` with eager argument instead. https://vitejs.dev/guide/migration#removed-deprecated-apis vitejs/vite#14118
rockwellll
added a commit
to rockwellll/vite_ruby
that referenced
this pull request
Jan 17, 2024
The `globEager` function was deprecated as of Vite 3.0 and has been removed in Vite 5.0. This updates the README to use the suggested `glob` with eager argument instead. https://vitejs.dev/guide/migration#removed-deprecated-apis vitejs/vite#14118
ElMassimo
pushed a commit
to ElMassimo/vite_ruby
that referenced
this pull request
Jan 17, 2024
* docs: update readme to reflect vite's deprecation of globEager The `globEager` function was deprecated as of Vite 3.0 and has been removed in Vite 5.0. This updates the README to use the suggested `glob` with eager argument instead. https://vitejs.dev/guide/migration#removed-deprecated-apis vitejs/vite#14118 * Update method reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
import.meta.globEageris deprecated since 3.0.0.https://v3.vitejs.dev/guide/migration.html#:~:text=import.meta.globEager%20is%20now%20deprecated.%20Use%20import.meta.glob(%27*%27%2C%20%7B%20eager%3A%20true%20%7D)%20instead.
This PR removes
import.meta.globEager(and the non-documentedimport.meta.globEagerDefault).Additional context
I don't remember whether we discussed about this one, but I think it's fine to remove this, because it's been deprecated for more than one year. (v3.0.0 was released on Jul 13th, 2022)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).