Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use http-compression dependency #11815

Closed
wants to merge 1 commit into from

Conversation

Kikobeats
Copy link

@Kikobeats Kikobeats commented Jan 25, 2023

Hello,

The current HTTP compression middleware implementation was copied/pasted from another polka PR and added a time ago.

This PR is introducing to use http-compression instead, since now the co de is living as standalone package, and you can get the benefit of it (like it's well tested and maintained).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Kikobeats
Copy link
Author

oh, I missed adding types ☹️

@bluwy
Copy link
Member

bluwy commented Apr 1, 2023

Not sure if you've gotten consent from the original author of the code to re-package it, but we need confirmation on that before we can accept this. Thanks!

@bluwy bluwy marked this pull request as draft April 1, 2023 10:02
@patak-dev
Copy link
Member

Thanks for the PR @Kikobeats, I agree with @bluwy here that we need a clear signal from the original author since your package now has your copyright and only a thanks note. But once that happens, given that there aren't improvements over the original code, I think it is better for us to stick with our own version in Core until we see a need to justify this change. Let's close this PR for now.

@patak-dev patak-dev closed this Apr 19, 2023
@Kikobeats Kikobeats deleted the http-compression branch April 19, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants