fix(config): resolve externalized specifier with internal resolver #10683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p4-important
bluwy
approved these changes
Oct 28, 2022
|
@sapphi-red Friendly suggestion: Some review comments on your changes would help me understand your PRs better when I'm rebasing my fork in the future 😇 |
aleclarson
reviewed
Nov 13, 2022
| * @deprecated In future, `conditions` will work like this. | ||
| * @internal | ||
| */ | ||
| overrideConditions?: string[] |
There was a problem hiding this comment.
What does this do? Hard to know from just reading the code.
There was a problem hiding this comment.
Ok I think I get it.
This option decides which of the default conditions (production, development, module) are allowed. It may also add custom conditions, and it prevents the conditions option from being used.
aleclarson
reviewed
Nov 13, 2022
| if (options.overrideConditions) { | ||
| conditions.push( | ||
| ...options.overrideConditions.filter((condition) => | ||
| conditionalConditions.has(condition) |
There was a problem hiding this comment.
This looks like a typo.
The has check should be negated, yes?
There was a problem hiding this comment.
Good catch! Thanks. I'll fix it with some refactor around this.
7 tasks
aleclarson
added a commit
to aleclarson/vite
that referenced
this pull request
Nov 14, 2022
Bug introduced in vitejs#10683 Some packages use "require" instead of "default" for CJS entry
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #10528 and implementes the first suggestion of #10495.
import-meta-resolvedidn't work with yarn (#10652) and this PR fixes that.This PR also fixes #10649. (But I don't consider this as a regression. That import should be imported with extension
tailwindcss/plugin.js)fixes #10649
fixes #10652
refs #10254 #10495 #10528
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).