@vitejs/plugin-legacy does not use browserslistrc #2476

fairbanksg · 2021-03-11T21:21:41Z

⚠️ IMPORTANT ⚠️ Please do not ignore this template. If you do, your issue will be closed immediately.

Read the docs.
Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
This is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

Describe the bug

@vitejs/plugin-legacy does not use browserlist config files. When the targets option is not specified, it is defaulted to defaults, which means @babel/present-env will use that target rather than .browserslistrc.

Reproduction

import { defineConfig } from 'vite'
import legacy from '@vitejs/plugin-legacy'

export default defineConfig({
  plugins: [legacy()]
})

System Info

vite version: 2.0.5
Operating System: macOS 11.2.2
Node version: 14.16.0
Package manager (npm/yarn/pnpm) and version: yarn 1.22.10

Logs (Optional if provided reproduction)

With no targets option

[@vitejs/plugin-legacy] legacy polyfills: Set(95) {
  'core-js/modules/es.symbol.js',
  'core-js/modules/es.symbol.description.js',
  'core-js/modules/es.object.to-string.js',
  'core-js/modules/es.symbol.iterator.js',
  'core-js/modules/es.string.iterator.js',
  'core-js/modules/es.array.iterator.js',
  'core-js/modules/web.dom-collections.iterator.js',
  'core-js/modules/es.symbol.async-iterator.js',
  'core-js/modules/es.symbol.to-string-tag.js',
  'core-js/modules/es.math.to-string-tag.js',
  'core-js/modules/es.json.to-string-tag.js',
  'core-js/modules/es.object.get-prototype-of.js',
  'core-js/modules/es.function.name.js',
  'core-js/modules/es.promise.js',
  'core-js/modules/es.regexp.to-string.js',
  'core-js/modules/web.dom-collections.for-each.js',
  'core-js/modules/es.array.slice.js',
  'core-js/modules/es.number.constructor.js',
  'core-js/modules/es.number.to-fixed.js',
  'core-js/modules/es.array.join.js',
  'core-js/modules/es.array.map.js',
  'core-js/modules/es.array.filter.js',
  'core-js/modules/es.string.split.js',
  'core-js/modules/es.regexp.exec.js',
  'core-js/modules/es.array.splice.js',
  'core-js/modules/es.object.assign.js',
  'core-js/modules/es.object.get-own-property-descriptor.js',
  'core-js/modules/es.array.concat.js',
  'core-js/modules/es.weak-set.js',
  'core-js/modules/es.string.replace.js',
  'core-js/modules/web.url.to-json.js',
  'core-js/modules/es.object.keys.js',
  'core-js/modules/esnext.global-this.js',
  'core-js/modules/es.regexp.constructor.js',
  'core-js/modules/es.array.includes.js',
  'core-js/modules/es.string.includes.js',
  'regenerator-runtime/runtime.js',
  'core-js/modules/es.object.get-own-property-descriptors.js',
  'core-js/modules/web.url.js',
  'core-js/modules/es.string.search.js',
  'core-js/modules/es.string.match.js',
  'core-js/modules/es.string.trim.js',
  'core-js/modules/es.array.find.js',
  'core-js/modules/es.array.reduce.js',
  'core-js/modules/es.set.js',
  'core-js/modules/es.string.sub.js',
  'core-js/modules/es.array.from.js',
  'core-js/modules/es.map.js',
  'core-js/modules/es.string.starts-with.js',
  'core-js/modules/es.string.ends-with.js',
  'core-js/modules/es.weak-map.js',
  'core-js/modules/es.string.pad-start.js',
  'core-js/modules/es.object.values.js',
  'core-js/modules/es.array.find-index.js',
  'core-js/modules/es.number.epsilon.js',
  'core-js/modules/es.object.get-own-property-names.js',
  'core-js/modules/es.object.is.js',
  'core-js/modules/es.object.freeze.js',
  'core-js/modules/es.typed-array.uint32-array.js',
  'core-js/modules/es.typed-array.copy-within.js',
  'core-js/modules/es.typed-array.every.js',
  'core-js/modules/es.typed-array.fill.js',
  'core-js/modules/es.typed-array.filter.js',
  'core-js/modules/es.typed-array.find.js',
  'core-js/modules/es.typed-array.find-index.js',
  'core-js/modules/es.typed-array.for-each.js',
  'core-js/modules/es.typed-array.includes.js',
  'core-js/modules/es.typed-array.index-of.js',
  'core-js/modules/es.typed-array.iterator.js',
  'core-js/modules/es.typed-array.join.js',
  'core-js/modules/es.typed-array.last-index-of.js',
  'core-js/modules/es.typed-array.map.js',
  'core-js/modules/es.typed-array.reduce.js',
  'core-js/modules/es.typed-array.reduce-right.js',
  'core-js/modules/es.typed-array.reverse.js',
  'core-js/modules/es.typed-array.set.js',
  'core-js/modules/es.typed-array.slice.js',
  'core-js/modules/es.typed-array.some.js',
  'core-js/modules/es.typed-array.sort.js',
  'core-js/modules/es.typed-array.subarray.js',
  'core-js/modules/es.typed-array.to-locale-string.js',
  'core-js/modules/es.typed-array.to-string.js',
  'core-js/modules/es.object.is-frozen.js',
  'core-js/modules/es.reflect.own-keys.js',
  'core-js/modules/es.reflect.get-own-property-descriptor.js',
  'core-js/modules/es.string.link.js',
  'core-js/modules/es.array-buffer.constructor.js',
  'core-js/modules/es.reflect.construct.js',
  'core-js/modules/es.promise.finally.js',
  'core-js/modules/es.array.flat-map.js',
  'core-js/modules/es.array.unscopables.flat-map.js',
  'core-js/modules/es.math.sinh.js',
  'core-js/modules/es.math.cosh.js',
  'core-js/modules/es.string.repeat.js',
  'core-js/modules/es.typed-array.float32-array.js'
}

With targets set to same value as in my .browserslistrc (>0.2%, not dead, not op_mini all)

[@vitejs/plugin-legacy] legacy polyfills: Set(101) {
  'core-js/modules/es.symbol.js',
  'core-js/modules/es.symbol.description.js',
  'core-js/modules/es.object.to-string.js',
  'core-js/modules/es.symbol.iterator.js',
  'core-js/modules/es.string.iterator.js',
  'core-js/modules/es.array.iterator.js',
  'core-js/modules/web.dom-collections.iterator.js',
  'core-js/modules/es.symbol.async-iterator.js',
  'core-js/modules/es.symbol.to-string-tag.js',
  'core-js/modules/es.math.to-string-tag.js',
  'core-js/modules/es.json.to-string-tag.js',
  'core-js/modules/es.object.get-prototype-of.js',
  'core-js/modules/es.function.name.js',
  'core-js/modules/es.promise.js',
  'core-js/modules/es.regexp.to-string.js',
  'core-js/modules/web.dom-collections.for-each.js',
  'core-js/modules/es.array.reverse.js',
  'core-js/modules/es.array.slice.js',
  'core-js/modules/es.number.constructor.js',
  'core-js/modules/es.number.to-fixed.js',
  'core-js/modules/es.array.join.js',
  'core-js/modules/es.array.map.js',
  'core-js/modules/es.array.filter.js',
  'core-js/modules/es.array.sort.js',
  'core-js/modules/es.string.split.js',
  'core-js/modules/es.regexp.exec.js',
  'core-js/modules/es.array.index-of.js',
  'core-js/modules/es.array.splice.js',
  'core-js/modules/es.object.assign.js',
  'core-js/modules/es.object.get-own-property-descriptor.js',
  'core-js/modules/es.array.concat.js',
  'core-js/modules/es.weak-set.js',
  'core-js/modules/es.string.replace.js',
  'core-js/modules/es.date.to-json.js',
  'core-js/modules/web.url.to-json.js',
  'core-js/modules/es.object.keys.js',
  'core-js/modules/esnext.global-this.js',
  'core-js/modules/es.regexp.constructor.js',
  'core-js/modules/es.array.includes.js',
  'core-js/modules/es.string.includes.js',
  'regenerator-runtime/runtime.js',
  'core-js/modules/es.object.get-own-property-descriptors.js',
  'core-js/modules/web.url.js',
  'core-js/modules/es.string.search.js',
  'core-js/modules/es.string.match.js',
  'core-js/modules/es.string.trim.js',
  'core-js/modules/es.array.find.js',
  'core-js/modules/es.array.reduce.js',
  'core-js/modules/es.set.js',
  'core-js/modules/es.string.sub.js',
  'core-js/modules/es.array.from.js',
  'core-js/modules/es.map.js',
  'core-js/modules/es.string.starts-with.js',
  'core-js/modules/es.string.ends-with.js',
  'core-js/modules/es.array.last-index-of.js',
  'core-js/modules/es.weak-map.js',
  'core-js/modules/es.string.pad-start.js',
  'core-js/modules/es.object.values.js',
  'core-js/modules/es.array.find-index.js',
  'core-js/modules/es.number.epsilon.js',
  'core-js/modules/es.object.get-own-property-names.js',
  'core-js/modules/es.object.is.js',
  'core-js/modules/es.object.freeze.js',
  'core-js/modules/es.typed-array.uint32-array.js',
  'core-js/modules/es.typed-array.copy-within.js',
  'core-js/modules/es.typed-array.every.js',
  'core-js/modules/es.typed-array.fill.js',
  'core-js/modules/es.typed-array.filter.js',
  'core-js/modules/es.typed-array.find.js',
  'core-js/modules/es.typed-array.find-index.js',
  'core-js/modules/es.typed-array.for-each.js',
  'core-js/modules/es.typed-array.includes.js',
  'core-js/modules/es.typed-array.index-of.js',
  'core-js/modules/es.typed-array.iterator.js',
  'core-js/modules/es.typed-array.join.js',
  'core-js/modules/es.typed-array.last-index-of.js',
  'core-js/modules/es.typed-array.map.js',
  'core-js/modules/es.typed-array.reduce.js',
  'core-js/modules/es.typed-array.reduce-right.js',
  'core-js/modules/es.typed-array.reverse.js',
  'core-js/modules/es.typed-array.set.js',
  'core-js/modules/es.typed-array.slice.js',
  'core-js/modules/es.typed-array.some.js',
  'core-js/modules/es.typed-array.sort.js',
  'core-js/modules/es.typed-array.subarray.js',
  'core-js/modules/es.typed-array.to-locale-string.js',
  'core-js/modules/es.typed-array.to-string.js',
  'core-js/modules/es.array-buffer.slice.js',
  'core-js/modules/es.object.is-frozen.js',
  'core-js/modules/es.reflect.own-keys.js',
  'core-js/modules/es.reflect.get-own-property-descriptor.js',
  'core-js/modules/es.string.link.js',
  'core-js/modules/es.array-buffer.constructor.js',
  'core-js/modules/es.reflect.construct.js',
  'core-js/modules/es.promise.finally.js',
  'core-js/modules/es.array.flat-map.js',
  'core-js/modules/es.array.unscopables.flat-map.js',
  'core-js/modules/es.math.sinh.js',
  'core-js/modules/es.math.cosh.js',
  'core-js/modules/es.string.repeat.js',
  'core-js/modules/es.typed-array.float32-array.js'
}

The text was updated successfully, but these errors were encountered:

maxbublik · 2021-07-28T09:13:22Z

I can confirm that explicitly changing targets in plugin-legacy config does affect the size of polyfills-legacy.xxxxx.js file. While changing targets in .browserslistrc does not affect the size of the polyfills chunk.

BTW what's up with PR #2627

patak-dev · 2021-07-28T09:30:07Z

@maxbublik I don't know why the PR was closed, this should be fixed. PR welcomed, someone could start from that closed PR and send a new one against the latest version

close vitejs#2476

sapphi-red · 2022-11-14T13:43:03Z

browserslist is not working because plugin-legacy uses @babel/standalone that uses browser build of browserslist. (#10502 (comment))

Switching to @babel/core + @babel/preset-env will make it work. But will bloat the dependencies that needs to be installed.

Handling browserslist on plugin-legacy or bundling babel on our side might increase maintenance burden.

KAROTT7 · 2022-12-11T13:04:51Z

@sapphi-red By my test, it doesn't add additional dependency and increase bundle sizes, please see comparison results:

use @babel/standalone

- use `@babel/core` and `@babel/preset-env`

and it will not result in break change, because @babel/standalone's core api (transform*) is from @babel/core, and @babel/standalone has include @babel/preset-env.

sapphi-red · 2022-12-11T13:30:44Z

@KAROTT7 I was not talking about neither the dependency size nor the bundle size. I was talking about the number of dependencies (including transitive ones). The number of dependencies affects the install time.

Anyway, in the last meeting, we decided to switch to @babel/core + @babel/preset-env. Would you like to send a PR?

gunta · 2022-12-21T07:23:19Z

Since babel/preset-env defaults to looking for browserlistrc, I was expecting the same here.
Looking forward to this being merged.

…11318) Co-authored-by: 翠 / green <[email protected]> fixes #2476

…itejs#11318) Co-authored-by: 翠 / green <[email protected]> fixes vitejs#2476

fairbanksg added the pending triage label Mar 11, 2021

yyx990803 added the plugin: legacy label Mar 15, 2021

anncwb mentioned this issue Mar 21, 2021

fix(plugin-legacy): ensure to use the configuration of .browserslistrc #2627

Closed

9 tasks

anncwb added bug and removed pending triage labels Mar 21, 2021

erm1116 added a commit to erm1116/vite that referenced this issue Feb 12, 2022

fix(plugin-legacy): fix to use the browserslist configuration

cb2fdf0

close vitejs#2476

erm1116 mentioned this issue Feb 12, 2022

fix(plugin-legacy): fix to use the browserslist configuration (fix #2476) #6880

Closed

9 tasks

sapphi-red mentioned this issue May 31, 2022

@vitejs/plugin-legacy modernPolyfill is not affected by target/browserslist/source code #8399

Closed

7 tasks

kingyue737 mentioned this issue Sep 22, 2022

fix(plugin-legacy): force set build.target #10072

Merged

9 tasks

sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 14, 2022

sapphi-red added this to Team Board Nov 14, 2022

sapphi-red moved this to Discussing in Team Board Nov 14, 2022

sapphi-red removed this from Team Board Nov 14, 2022

sapphi-red added this to Team Board Nov 14, 2022

sapphi-red moved this to Discussing in Team Board Nov 14, 2022

This was referenced Nov 14, 2022

[plugin-legacy] Custom usage stats in browserslist-stats.json broken #10502

Closed

vite-plugin-legacy ignoreBrowserslistConfig option not working #10916

Closed

sapphi-red mentioned this issue Nov 29, 2022

plugin-legacy can not detect browserslist config #11100

Closed

7 tasks

patak-dev moved this from Discussing to Changes Requested in Team Board Dec 1, 2022

KAROTT7 mentioned this issue Dec 11, 2022

fix(plugin-legacy)!: support browserslist and update default target #11318

Merged

9 tasks

meduzen mentioned this issue Dec 30, 2022

Update Vite to 4 Sunappu-Dojo/burokku#54

Merged

patak-dev closed this as completed in #11318 Feb 2, 2023

patak-dev pushed a commit that referenced this issue Feb 2, 2023

fix(plugin-legacy)!: support browserslist and update default target (#…

d5b8f86

…11318) Co-authored-by: 翠 / green <[email protected]> fixes #2476

github-actions bot locked and limited conversation to collaborators Feb 17, 2023

futurGH pushed a commit to futurGH/vite that referenced this issue Feb 26, 2023

fix(plugin-legacy)!: support browserslist and update default target (v…

b87f776

…itejs#11318) Co-authored-by: 翠 / green <[email protected]> fixes vitejs#2476

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@vitejs/plugin-legacy does not use browserslistrc #2476

@vitejs/plugin-legacy does not use browserslistrc #2476

fairbanksg commented Mar 11, 2021

maxbublik commented Jul 28, 2021

patak-dev commented Jul 28, 2021

sapphi-red commented Nov 14, 2022

KAROTT7 commented Dec 11, 2022

sapphi-red commented Dec 11, 2022 •

edited

Loading

gunta commented Dec 21, 2022

@vitejs/plugin-legacy does not use browserslistrc #2476

@vitejs/plugin-legacy does not use browserslistrc #2476

Comments

fairbanksg commented Mar 11, 2021

Describe the bug

Reproduction

System Info

Logs (Optional if provided reproduction)

maxbublik commented Jul 28, 2021

patak-dev commented Jul 28, 2021

sapphi-red commented Nov 14, 2022

KAROTT7 commented Dec 11, 2022

sapphi-red commented Dec 11, 2022 • edited Loading

gunta commented Dec 21, 2022

sapphi-red commented Dec 11, 2022 •

edited

Loading