Skip to content

Commit

Permalink
chore: remove stale TODOs (#17866)
Browse files Browse the repository at this point in the history
  • Loading branch information
sapphi-red authored Aug 19, 2024
1 parent 3dc23d9 commit e012f29
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion packages/plugin-legacy/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
configFile: false,
compact: !!config.build.minify,
sourceMaps,
inputSourceMap: undefined, // sourceMaps ? chunk.map : undefined, `.map` TODO: moved to OutputChunk?
inputSourceMap: undefined,
presets: [
// forcing our plugin to run before preset-env by wrapping it in a
// preset so we can catch the injected import statements...
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/asset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ async function fileToBuiltUrl(
})
generatedAssets.get(config)!.set(referenceId, { originalFileName })

url = `__VITE_ASSET__${referenceId}__${postfix ? `$_${postfix}__` : ``}` // TODO_BASE
url = `__VITE_ASSET__${referenceId}__${postfix ? `$_${postfix}__` : ``}`
}

cache.set(id, url)
Expand Down
4 changes: 2 additions & 2 deletions packages/vite/src/node/ssr/ssrManifestPlugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
export function ssrManifestPlugin(config: ResolvedConfig): Plugin {
// module id => preload assets mapping
const ssrManifest: Record<string, string[]> = {}
const base = config.base // TODO:base
const base = config.base

return {
name: 'vite:ssr-manifest',
Expand Down Expand Up @@ -78,7 +78,7 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin {
const chunk = bundle[filename] as OutputChunk | undefined
if (chunk) {
chunk.viteMetadata!.importedCss.forEach((file) => {
deps.push(joinUrlSegments(base, file)) // TODO:base
deps.push(joinUrlSegments(base, file))
})
chunk.imports.forEach(addDeps)
}
Expand Down

0 comments on commit e012f29

Please sign in to comment.