fix: invalidate import globs upon new/removed files (fix #3499) (#3500)

vitejs · May 21, 2021 · b31604e · b31604e
1 parent 06b9935
commit b31604e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/playground/glob-import/__tests__/glob-import.spec.ts b/packages/playground/glob-import/__tests__/glob-import.spec.ts
@@ -59,7 +59,13 @@ if (!isBuild) {
       JSON.stringify(
         {
           '/dir/a.js': {},
-          ...allResult
+          ...allResult,
+          '/dir/index.js': {
+            modules: {
+              './a.js': {},
+              ...allResult['/dir/index.js'].modules
+            }
+          }
         },
         null,
         2
@@ -75,7 +81,15 @@ if (!isBuild) {
           '/dir/a.js': {
             msg: 'a'
           },
-          ...allResult
+          ...allResult,
+          '/dir/index.js': {
+            modules: {
+              './a.js': {
+                msg: 'a'
+              },
+              ...allResult['/dir/index.js'].modules
+            }
+          }
         },
         null,
         2

diff --git a/packages/vite/src/node/server/hmr.ts b/packages/vite/src/node/server/hmr.ts
@@ -181,6 +181,9 @@ export async function handleFileAddUnlink(
       const relative = path.relative(base, file)
       if (match(relative, pattern)) {
         modules.push(module)
+        // We use `onFileChange` to invalidate `module.file` so that subsequent `ssrLoadModule()`
+        // calls get fresh glob import results with(out) the newly added(/removed) `file`.
+        server.moduleGraph.onFileChange(module.file!)
       }
     }
   }