fix: handle using compiler with React 18

[ArnaudBarre]

Fix #328

[ArnaudBarre]

I'm surprised vite build just let the require from a local package without type: module pass though like this, feel like a bug in Vite.

[hi-ogawa]

I'm surprised vite build just let the require from a local package without type: module pass though like this, feel like a bug in Vite.

I just ran locally and I get what you mean. I think I've seen something similar when my transform plugin accidentally injected export ... into react cjs package which had require. (I actually I wasn't sure at that time, but now seeing this issue, I'm guessing that was the case.)

Not sure why React team wrote that, but I think we can simply pick esm or cjs? I'll comment what I tested locally.

[ArnaudBarre]

Yeah for sure using ESM is good solution, but the official gist provided by @poteto uses require so other people maybe have trouble with it?

@poteto are you ok with changing your gist to use ESM syntax? I think all frameworks/toolchains support it

[poteto]

yeah either works, the gist is just a reference

[wong2]

Any updates?

[ArnaudBarre]

@poteto yeah I know but default matters and I think that 9 years after ESM being spec, using them for client code will be better than an import style that never worked in browsers.