Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add jsx dev runtime to optimizeDeps #147

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: add jsx dev runtime to optimizeDeps #147

merged 1 commit into from
Apr 17, 2023

Conversation

ArnaudBarre
Copy link
Member

Rollback part of the change from #132 because it makes cold start slower for storybook. Two differences from what is actually published:

  • We don't force the default for esbuild. This allow TS only projects to handle multiple jsx runtime. It's very edge case, but doesn't cost anything to let it open because 'react' is also the default for esbuild.
  • We take into account the option for optimizeDeps so that works for other runtimes

@ArnaudBarre ArnaudBarre merged commit 3bbd8f0 into main Apr 17, 2023
@ArnaudBarre ArnaudBarre deleted the dev-runtime branch April 17, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@brillout brillout brillout approved these changes

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red Awaiting requested review from sapphi-red

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArnaudBarre @patak-dev @brillout @bluwy