Use built-in CMake support when CMake >= 3.28 #25
Conversation
|
Tested locally on Linux with Ninja and Clang++ 17, and on Windows with VS2022, using the latest CMake 3.28 release candidate. May be worth having dedicated testing in the CI plan for this, may need to some pointers as to what's the best way to proceed (we would need to have CMake 3.28 installed and set up, and so on...) |
| if(CMAKE_VERSION VERSION_LESS 3.28) | ||
| target_sources(${name} PRIVATE ${sources}) | ||
| else() | ||
| target_sources(${name} PUBLIC FILE_SET fmt_module TYPE CXX_MODULES FILES ${sources}) | ||
| endif() |
There was a problem hiding this comment.
I think it's better to restructure the code to check CMake version in one place instead of three, something like:
if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.28)
target_sources(${name} PUBLIC FILE_SET fmt_module TYPE CXX_MODULES FILES ${sources})
return()
endif ()earlier in this function
Also note spaces before opening parentheses in statement-like constructs like if.
It would be good to have a CI config for this. Here's an example how to install necessary packages: |
|
Closing for now but let me know if you plan to address the remaining comment(s) and I'll reopen. |
CMake 3.28 enables support for module handling using dependency scanning (when using a supported compiler and generator): https://cmake.org/cmake/help/latest/release/3.28.html
Note that for dependency scanning to be enabled automatically, the policy level needs to be 3.28 or higher. Wonder if it's worth setting that from here or not (or at least an error/warning if it isn't).