Skip to content

Commit

Permalink
set min pw version to 1.42
Browse files Browse the repository at this point in the history
  • Loading branch information
vitalets committed Oct 29, 2024
1 parent 638acc8 commit 3dcae17
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-win.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
# take min and max supported PW versions
playwrightVersion: ['1.38', 'latest', 'beta']
playwrightVersion: ['1.42', 'latest', 'beta']
defaults:
run:
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
id: get-versions
with:
script: |
const minimalVersion = '1.38';
const minimalVersion = '1.42';
const { execSync } = require('node:child_process');
const info = execSync('npm show --json @playwright/test').toString();
const { versions } = JSON.parse(info);
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changelog

## Dev
* increase minimal Playwright version from 1.35 to 1.38
* increase minimal Playwright version from 1.35 to 1.42
* support scoped step definitions ([#205](https://github.com/vitalets/playwright-bdd/issues/205))
* new config option `missingSteps` to setup different behavior when step definitions are missing ([#158](https://github.com/vitalets/playwright-bdd/issues/158))
* new config option `matchKeywords` to enable keyword matching when searching for step definitions ([#221](https://github.com/vitalets/playwright-bdd/issues/221))
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
"engines": {
"node": ">=18"
},
"peerDependencies": {
"@playwright/test": ">=1.42"
},
"main": "./dist/index.js",
"exports": {
".": "./dist/index.js",
Expand Down Expand Up @@ -52,9 +55,6 @@
"pw": "npm i --no-save @playwright/test@$PW @playwright/experimental-ct-react@$PW",
"release": "bash scripts/release.sh"
},
"peerDependencies": {
"@playwright/test": ">=1.38"
},
"dependencies": {
"@cucumber/cucumber-expressions": "17.1.0",
"@cucumber/gherkin": "29.0.0",
Expand Down

0 comments on commit 3dcae17

Please sign in to comment.