Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pgvectorscale tasks execution in check_mode #846

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

vitabaks
Copy link
Owner

@vitabaks vitabaks commented Dec 13, 2024

Added the check_mode: false parameter for the pgvectorscale tasks.

This ensures that the task executes even in --check mode, preventing it from being skipped and ensuring the file is downloaded. This change addresses an error where subsequent tasks fail due to the missing downloaded archive.

Fixed:

TASK [packages : Looking up the latest version of pgvectorscale] ***************
ok: [10.0.0.5]
TASK [packages : Download pgvectorscale archive] *******************************
changed: [10.0.0.5]
TASK [packages : Extract pgvectorscale package] ********************************
fatal: [10.0.0.5]: FAILED! => {"changed": false, "msg": "Source '/tmp/pgvectorscale-0.5.1-pg16-amd64.zip' does not exist"}

Added the check_mode: false parameter to the task responsible for downloading the pgvectorscale archive using the ansible.builtin.get_url module. This ensures that the task executes even in --check mode, preventing it from being skipped and ensuring the file is downloaded. This change addresses an error where subsequent tasks fail due to the missing downloaded archive.
@vitabaks vitabaks self-assigned this Dec 13, 2024
@vitabaks vitabaks changed the title Download pgvectorscale archive in check_mode Allow pgvectorscale tasks execution in check_mode Dec 13, 2024
@vitabaks vitabaks merged commit 6748f4f into master Dec 13, 2024
15 checks passed
@vitabaks vitabaks deleted the pgvectorscale-check-mode branch December 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant