Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firewalld/ufw support #705

Closed
wants to merge 5 commits into from
Closed

Add firewalld/ufw support #705

wants to merge 5 commits into from

Conversation

redy01
Copy link

@redy01 redy01 commented Jul 20, 2024

No description provided.

@redy01 redy01 changed the title #501 - Add firewalld/ufw support Add firewalld/ufw support Jul 20, 2024
@redy01 redy01 marked this pull request as ready for review July 20, 2024 22:32
@vitabaks
Copy link
Owner

vitabaks commented Jul 21, 2024

Hi @redy01

Thank you for your contribution!

I see that the tests are failing with an error: 'firewall_type' is undefined.

Try debug

    - name: Debug firewall_type
      ansible.builtin.debug:
        var: firewall_type

@redy01
Copy link
Author

redy01 commented Jul 21, 2024

Weird, because firewall_type is defined in vars/system.yml loaded in "pretasks" section at least in deploy play

@SDV109
Copy link
Contributor

SDV109 commented Jul 29, 2024

@redy01, Hi, please rename your branch, I can't make a git clone for a branch named #501

@redy01 redy01 closed this Aug 6, 2024
@redy01 redy01 deleted the #501 branch August 6, 2024 19:41
@redy01
Copy link
Author

redy01 commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants