Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of map legend items #987

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Mar 1, 2023

The categorical values in map legend were not sorted by position. Fixes Fixes #986

  • refactor: Use generic so the caller does not have to do as
  • feat: Sort map categorical legend values by position
  • fix: Prevent error flash on map

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner March 1, 2023 10:03
@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 10:14AM (UTC)

@ptbrowne ptbrowne changed the title refactor: Use generic so the caller does not have to do as Sorting of map legend items Mar 1, 2023
ptbrowne added 2 commits March 1, 2023 11:09
Do not fetch geoshapes or symbols if iri is falsy
Otherwise we had a cannot find dimension error
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ptbrowne ptbrowne merged commit 374ae8c into main Mar 1, 2023
@ptbrowne ptbrowne deleted the fix/map-categorical-legend-sorting branch March 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema:position not used to order chart legends
2 participants