fix: Search performance and empty results #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the search was broken due to empty list of IRIs
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Prevent combinatorial explosion due to languages differences between search rows
ptbrowne
changed the title
bprusinowski
approved these changes
Feb 15, 2023
Comment on lines
+171
to
+173
| FILTER(LANG(?name) = LANG(?description)) | ||
| FILTER(LANG(?name) = LANG(?creatorLabel)) | ||
| FILTER(LANG(?name) = LANG(?themeName)) |
There was a problem hiding this comment.
I edited the description, please tell me if it's clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes on search
Previously the table returned in the results would be like so
cubeIRIcubethemecreatorSo for a single cube we would have 4 (more generally N_LANGUAGE*N_FIELDS_WITH_LANGUAGE) different rows instead of 2 (one row for each language). The added equality filter ensures each row is in the same language.
Fix #963
Fix #959