Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #955

Merged
merged 10 commits into from
Feb 14, 2023
Merged

Performance improvements #955

merged 10 commits into from
Feb 14, 2023

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 3, 2023

Introduce LRU caches for some SPARQL queries that could take a long time (>1000ms).
Due to the nature of LRU caches, queries that are not used are removed from the cache.
If a dataset has not been opened yet, it takes time since the cache is not primed but then all interactions with the dataset are snappier.

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 0:03AM (UTC)

@ptbrowne ptbrowne changed the title refactor: Parse early Performance improvements Feb 6, 2023
@ptbrowne ptbrowne marked this pull request as ready for review February 6, 2023 16:08
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

app/rdf/query-dimension-values.ts Outdated Show resolved Hide resolved
app/rdf/query-cache.ts Outdated Show resolved Hide resolved
@Rdataflow
Copy link
Contributor

this PR brings up an interesting idea. Will there be a way to disable this cache? (i.e. url param cache=false which could be applied for E2E tests scenarios)

@ptbrowne ptbrowne merged commit fb87d10 into main Feb 14, 2023
@ptbrowne ptbrowne deleted the feat/lru-cache branch February 14, 2023 09:04
@ptbrowne
Copy link
Collaborator Author

If the need arise, it will be quite straightforward to support this kind of option.

@Rdataflow
Copy link
Contributor

@ptbrowne fine, so let me pronounce the need for it. we need it to have representative comparable performance tests. see also #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants