-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements #955
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
this PR brings up an interesting idea. Will there be a way to disable this cache? (i.e. url param |
If the need arise, it will be quite straightforward to support this kind of option. |
Introduce LRU caches for some SPARQL queries that could take a long time (>1000ms).
Due to the nature of LRU caches, queries that are not used are removed from the cache.
If a dataset has not been opened yet, it takes time since the cache is not primed but then all interactions with the dataset are snappier.