Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Metadata panel v2 #913

Merged
merged 17 commits into from
Nov 29, 2022
Merged

feat: Metadata panel v2 #913

merged 17 commits into from
Nov 29, 2022

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Nov 28, 2022 •
edited
Loading

This PR includes enhancements to the metadata panel.

  • Tab switching animations
  • Expandable dimension description
  • Autocomplete (jump to)
  • Way of opening the panel by clicking on values in chart (and remove tooltips)
  • Do not share state across one store
  • Shrinking of chart after the panel is opened in published / embed mode

How to test

  1. Start creation of a chart (using e.g. Einmalvergütung für Photovoltaikanlagen dataset).
  2. See that a Metadata button is visible in the top right corner of a chart.
  3. Click the button an see a panel is being opened.
  4. It's also possible to jump to a dimension by clicking on a filter name (above the chart, e.g. Kanton) or a select element's label (in left filters panel).
  5. Publish a chart and see that the panel is attached to a chart container instead of the left side of the browser window.

@vercel
Copy link

vercel bot commented Nov 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 4:30PM (UTC)

@bprusinowski bprusinowski force-pushed the feat/metadata-panel branch 2 times, most recently from a12389d to 625be1b Compare November 28, 2022 13:56
@bprusinowski bprusinowski changed the title feat: Add an ability to expand details of dimension feat: Metadata panel v2 Nov 28, 2022
@bprusinowski bprusinowski marked this pull request as ready for review November 28, 2022 13:58
ptbrowne
ptbrowne approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM ! Thanks !

ptbrowne
ptbrowne approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@ptbrowne
Copy link
Collaborator

ptbrowne commented Nov 29, 2022 •
edited
Loading

When I go to a test chart, I have this problem, do you know why ?
https://visualization-tool-2vrohf3kn-ixt1.vercel.app/__test/int/scatterplot-palmer-penguins

image

@bprusinowski bprusinowski merged commit bc0b3a5 into main Nov 29, 2022
@bprusinowski bprusinowski deleted the feat/metadata-panel branch November 29, 2022 16:25
@bprusinowski bprusinowski linked an issue Nov 29, 2022 that may be closed by this pull request
Implement a 1st version of the metadata panel #801
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a 1st version of the metadata panel
2 participants
@bprusinowski @ptbrowne