Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open search result only on title #839

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

ptbrowne
Copy link
Collaborator

Open search results only on title

Hover effect on all the search result is misleading since the chips for themes / organisations can
be clicked. Here only the title is clickable, and it gets an underline on hover.

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:59PM (UTC)

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the cursor shouldn't be a pointer if clicking on a whole tile is not doing anything, I think it should only be visible when hovering over the title 👁️

},
"&:hover .MuiTypography-body1": {
fontWeight: "bold",
"& .MuiTypography-body1": {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty {}?

@ptbrowne ptbrowne merged commit 804218e into main Nov 10, 2022
@ptbrowne ptbrowne deleted the feat/click-search-result branch November 10, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants