feat: Show tree in MultiFilters #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
force-pushed
the
feat/hierarchies-ui-refinements
branch
from
ba2f22c to
9dc96b0
Compare
ptbrowne
reviewed
Nov 9, 2022
bprusinowski
force-pushed
the
feat/hierarchies-ui-refinements
branch
from
6392da7 to
915936b
Compare
|
@ptbrowne I will take a look at the E2E test, but I am not sure if the error is related to changes from this PR (data loading error). |
ptbrowne
reviewed
Nov 10, 2022
ptbrowne
reviewed
Nov 10, 2022
ptbrowne
reviewed
Nov 10, 2022
| <FilterControls | ||
| selectAll={() => setPendingValues(flatOptions)} | ||
| selectNone={() => setPendingValues([])} | ||
| allKeysLength={flatOptions.length} |
There was a problem hiding this comment.
I guess there should be a uniqueBy value here otherwise we can count twice values that are multiple times in the tree.
ptbrowne
reviewed
Nov 10, 2022
|
Thanks for the review @ptbrowne. For the first point, we include the color checkbox for all values, it's then visible or hidden based on The second point should also be ok after the changes. |
bprusinowski
force-pushed
the
feat/hierarchies-ui-refinements
branch
from
bbfc662 to
20b234d
Compare
ptbrowne
approved these changes
Nov 14, 2022
ptbrowne
force-pushed
the
feat/hierarchies-ui-refinements
branch
from
04c8e56 to
32f22d2
Compare
This is a temporary fix for something that seems like a bigger problem. The symptom was that during the edition.spec tests, we'd have a data loading error in place of the chart. This is because inside the observationsQuery, one of the pattern has an undefined subject. The pattern is the one $cubeNode cube:observationSet ?observationSet0. Here, $cubeNode is a NamedNode whose term should be the cube iri. However here, the cube iri is undefined. The cube iri is taken from the source, trying to find an outward edge with ns.view.cube and then getting the term from the result. The problem is that there is two edges from the source, one to the old version of the cube, and one to the new version. This causes the .term lookup here (https://github.com/zazuko/rdf-cube-view-query/blob/fac3834aadfdd3807ae96577ae12c9c5e865664e/lib/query/ViewQuery/Sources.js#L37) to return undefined (because there are two links), so "terms" should be used. The problem goes away when updating the cube from the config (since the old version is not loaded anymore), or when not using the cache (using directly getRawCube instead of cachedGetRawCube). We still do not know while not using the cache fixes the bad behavior. TLDR: When using the cached cube loader, we cannot load cubes with an old version: this seems to be because when we load several versions of a cube, the source node ends up having two outward links (one to the old version, one to the new version), instead of one outward link to the right cube.
ptbrowne
force-pushed
the
feat/hierarchies-ui-refinements
branch
from
32f22d2 to
fc2040d
Compare
This is a temporary fix for something that seems like a bigger problem. The symptom was that during the edition.spec tests, we'd have a data loading error in place of the chart. This is because inside the observationsQuery, one of the pattern has an undefined subject. The pattern is the one $cubeNode cube:observationSet ?observationSet0. Here, $cubeNode is a NamedNode whose term should be the cube iri. However here, the cube iri is undefined. The cube iri is taken from the source, trying to find an outward edge with ns.view.cube and then getting the term from the result. The problem is that there is two edges from the source, one to the old version of the cube, and one to the new version. This causes the .term lookup here (https://github.com/zazuko/rdf-cube-view-query/blob/fac3834aadfdd3807ae96577ae12c9c5e865664e/lib/query/ViewQuery/Sources.js#L37) to return undefined (because there are two links), so "terms" should be used. The problem goes away when updating the cube from the config (since the old version is not loaded anymore), or when not using the cache (using directly getRawCube instead of cachedGetRawCube). We still do not know while not using the cache fixes the bad behavior. TLDR: When using the cached cube loader, we cannot load cubes with an old version: this seems to be because when we load several versions of a cube, the source node ends up having two outward links (one to the old version, one to the new version), instead of one outward link to the right cube. To fix this bug, I disabled the cube loader's cache. This means that across request, we will not have a cache.
…hies-ui-refinements
…e-admin/visualization-tool into feat/hierarchies-ui-refinements
|
@ptbrowne I guess it's related to versioning / unversioning of observations as for some datasets values didn't match and this resulted in many duplicated values e.g. in some cases there were "https://abc.org" in "proper" dimension values, and when using the previous query they had a format of "https://abc-test.org". I think it was the case for Ausgaben dataset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #800.
Design specs
How to test
Look for a dataset with hierarchies (e.g. Bathing water quality (with Hierarchie) or Öffentliche Ausgaben TEST 3) and without hierarchies (e.g. Bathing water quality) and create a chart with color segmentation; afterwards edit filters to see if it works correctly.