Use a cube loader #819
Merged
Use a cube loader #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
force-pushed
the
perf/cube-loader
branch
from
2030cb2 to
37541b9
Compare
bprusinowski
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating queries, I noticed that we were loading the cubes a lot,
since the dataCubeByIri resolver is high and needs to load the cube shape.
Since the cube can be shared across resolvers, I used a loader.
Since the cube does not change a lot, I added also an application level
cache through the cachedWithTTL helper. This means that even across requests,
within a 60s timespan, the cube will be resolved through a cache.
How to test
Every interaction with cubes in the cube configurator should be faster.