-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New UI (search + dataset preview) #818
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaad399
to
44d882a
Compare
@AnninaWalker can you take a look at deployment preview and see if dataset highlighting on mouse over looks good? Previously we had some left padding applied to the cards so there was some space on the left side, not sure if it looks ok now 😅 |
e1b0415
to
cf9406b
Compare
Wow, I haven't looked at the code yet, but this looks really nice, kudos @AnninaWalker and @bprusinowski ! I love the header animation 💯 Concerning the hover, If you are talking about this @bprusinowski, I think you need to fix it 😁, |
Cool, thanks @ptbrowne! I am not 100% happy with the animation, as when you scroll down to select a dataset, it jumps to the top immediately and just after that it starts shrinking. I tried to "fix" this by animating the scroll up (as by default And for the hovering, I think the cursor should be there already, it's not a |
Ah sorry, for the pointer, I made a mistake, my focus was not on the window when I saw that. I see your point concerning the animation when you have scrolled down, it's true that it's a bit distracting. Maybe we could try to deactivate the animation altogether when the banner is not in the viewport ? |
Nit: Animation is a bit annoying when switching language LGTM at the moment for me 👍 |
Ah, good point about switching the language, I missed that. I'll try with the viewport suggestion + think about locale switch 🙇 |
YAY nice to see the new search layout in action and even animated! So cool! Regarding your questions @bprusinowski I think the highlighting of the dataset would need some padding. Maybe it could even extend to the line on the left? |
cf9406b
to
689811e
Compare
@AnninaWalker @ptbrowne I introduced the changes, I it should be better now :) I also managed to fix the locale switching animation problem, but it means that we will lack initial banner animation. Let me know if it's acceptable 😅 |
@bprusinowski LGTM. The only thing I was wondering is regarding the responsive behaviour, if the content shouldn't be centred? |
@AnninaWalker the whole site should "extend" to the available width, or the banner content should be centered (right now it's left-aligned to the content below)? Or should the banner take more space, to have the same width as the dataset results below? |
Currently the content below has at some point a fixed width and the content is aligned to the left, so when I extend my window, I get this white whole on the right. That's why I was wondering if we should center the content, as in the screenshot above. But maybe it doesn't make sense. I guess most people don't have such a huge screen as I do ;-) |
689811e
to
c93a335
Compare
8380563
to
f159b4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Closes #817.
This PR introduces new UI for search and dataset preview pages.