Sort legend items in case of hierarchy #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM 💯 |
bprusinowski
approved these changes
Oct 27, 2022
Would 1st go to the search page, search results, then create 🤷♂️
ptbrowne
force-pushed
the
fix/legend-items-sort
branch
from
216ca36 to
018b9c4
Compare
|
I changed the logic and I base myself on the labels received. This is because for some sorters we need the measures (byMeasure), and here we do not have it. Since the labels come already sorted, I figured we could remove the need for sorters here, and resort the hierarchy group entries according to the original order. |
bprusinowski
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of hierarchy, we would not sort legend items and instead rely
on hierarchy order, which is not what we want.
Fixes : #806
How to test
/en/create/new?cube=https://environment.ld.admin.ch/foen/nfi/49-19-44/cube/1