feat: Refinements to table column styles #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
approved these changes
Oct 27, 2022
...bar & heatmap only for numerical measures, categories for other dimensions
bprusinowski
force-pushed
the
feat/refinements-to-tables
branch
from
150d28c to
a166c0f
Compare
...if default colors are there
bprusinowski
force-pushed
the
feat/refinements-to-tables
branch
from
a166c0f to
65daecb
Compare
ptbrowne
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #808.
Previously we incorrectly enabled bar and heat map column style options for some dimension types; this PR improves that by enabling them only for numerical measures and allowing to use categories for other dimension types. It also moves a placeholder text "Select a dimension" to top, instead of being the last option.
Additionally, there is now a "dimension" color palette, which exists when there are pre-defined colors attached to dimension values; we are then able to select such palette from ColorPalette picker.
How to test
/en/browse/dataset/https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Ftest_ordinal_507%2F7?dataSource=Intord1dimension in Columns section.Categories.