fix: Pie chart initialization #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Do you think it would make sense to add a test to check the chart initialization logic ? Like open the editor for the dataset and checking that all the possible chart types button are not disabled ? |
bprusinowski
force-pushed
the
fix/pie-chart-initialization
branch
from
a646331 to
4f14969
Compare
|
I think a test is definitely a good idea, but I wonder if this should be an e2e test, or would a unit test be enough – I am not sure if there is benefit in having an e2e test for a given dataset, when the logic to what to display in the buttons is solely dependent on one function ( |
|
If the original issue would have been caught by an unit test, I think this is the best way to go :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #719.
This PR updates the pie chart to also consider geoDimensions for segment when it's initialized. Also there is a correction to possible chart types logic which should prevent such failures in the future.