Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add dimension descriptions to more places in UI #746

Merged
merged 6 commits into from
Sep 29, 2022
Merged

feat: Add dimension descriptions to more places in UI #746

merged 6 commits into from
Sep 29, 2022

Conversation

bprusinowski
Copy link
Collaborator

Closes #744.

@vercel
Copy link

vercel bot commented Sep 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
visualization-tool ✅ Ready (Inspect) Visit Preview Sep 29, 2022 at 10:43AM (UTC)

@bprusinowski bprusinowski marked this pull request as ready for review September 29, 2022 09:19
ptbrowne
ptbrowne approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Really nice. Only 1 suggestion about the MaybeTooltip that could be tackled if you have time. I remember that I had to do the wrapping the way you did and I was a bit unconfortable with the repeated element.

@bprusinowski bprusinowski force-pushed the feat/add-metadata-to-more-places-in-ui branch from 40fff5c to 08c307b Compare September 29, 2022 10:38
@bprusinowski bprusinowski merged commit f3168d9 into main Sep 29, 2022
@bprusinowski bprusinowski deleted the feat/add-metadata-to-more-places-in-ui branch September 29, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne ptbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata: Information from schema:description missing in the UI
2 participants
@bprusinowski @ptbrowne